Repository navigation
fix: reject reused PIDs during tree walks and WTS lookups - #29
Merged
Merged
Conversation
Sample the process-tree decision time before Toolhelp so a PID reused while the snapshot runs cannot pass the creation-time bound. Apply a WTS account only when a live open still names the same process, and treat a zero creation time as a failed identity query. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
End Process Tree and the process-list account fallback could treat a reused PID as the process that was just snapshotted.
CreateToolhelp32Snapshot. A process created while Toolhelp is running, including one that reused a frozen PID, fails the creation-time bound and is not terminated.query_process_identity_for_pidno longer returnsOkfor PID 0 or a zero creation time. Those values are the unverified sentinel.No new columns, pages, or dependencies. This does not touch the process-name filter or Startup page branches.
Tests
Unit tests cover a replacement born after the decision instant, a reused or exited PID on the WTS path, access-denied (still allowed, because the process cannot be opened), and a zero creation time. Windows CI runs the full suite; this host can only cross-check the MSVC target.