Repository navigation
Select affected local tests and prefer nextest for full Rust validation - #998
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document repository test selection and binary-only selectors. The Factory implement skill follows repository guidance and retains the full-suite fallback elsewhere.
Closes #724
Evidence
python3 -m unittest discover -s scripts -p test_affected_tests.pyfailed for missing site/release selection and for mixed changes dropping browser checks.After: all 12 selector tests pass, covering site, release, Rust, support/fakes, mixed, unknown, dirty files, rename, fallback and failures. All 14 tests pass with
python3 -m unittest discover -s scripts -p 'test_*.py'.cargo check --all-targetspasses.UPDATE_PROMPTS=1 cargo test prompts_pageregenerates only the expected skill paragraph;cargo test prompts_pagepasses all 11 tests afterward.npm test --prefix sitepasses all 36 browser tests on the regenerated page./usr/bin/time -p cargo nextest run(nextest 0.9.146, default profile, Linux, warm build): 2,223 passed, 2 skipped, across 52 binaries; 1,295.90s wall time (21m35.90s), including 0.32s reported build time. Nextest's test-only summary was 1,294.215s. This is a measurement of this host, not a demonstrated speedup overcargo test.f598872, including the Linux Rust suite, tooling checks, site/Console browser tests and macOS gate. The already-running local measurement completed without starting another full run.docs/testing.md. CI workflow and Delivery behavior are unchanged.Test seams
scripts/affected-tests <base>as a subprocess in a real scratch Git repository, observing exit status, printed selection, and external test-runner invocations.Review coverage
Independent Standards and Spec reviews against
mainfound no issues. Each axis read all six changed files, including the generated page's complete changed hunk. Unread changed files: none. Generated-output exclusions: none. Reports with each axis's final supporting-files list are retained in.thirdshift-review-mzw1W6/standards.mdand.thirdshift-review-mzw1W6/spec.mdin the worktree.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: validation
Conservative local selection and Factory testing guidance; CI and Delivery policy remain unchanged.
Built with codex · gpt-6.1-sol · high