Repository navigation
Name the owning Command in Run notification emails - #979
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run notification bodies name the owning Command and Pickup's dispatched run kind. Subjects, Architect/Security notifications, single-owner delivery and quiet skips keep their existing behavior.
Result: <outcome> Issue: <Issue URL> Title: <title> +Command: Run | Spec run | Pickup run, which dispatched a Run | Pickup run, which dispatched a Spec runCapture direct issue kind during notification setup so a failed Harness preflight still identifies a Spec run. Pickup retains the refreshed Ready issue's kind. Update the Run notification glossary entry.
Closes #709
Evidence
Command:text.After: the full suite passes, including all 123 notification and Pickup tests.
cargo test --test run_notification a_spec_with_missing_harness_still_names_its_command -- --exactfailed withCommand: Run.After: the same command passes with
Command: Spec run; its test is retained.cargo fmt --check,cargo clippy --all-targets -- -D warnings, and the fullcargo testsuite.Test seams
Review coverage
Independent Standards and Spec reviews used
mainas the fixed point and inspected all seven final changed files. No changed file was left unread by either axis; no generated-output exclusions. Standards: no findings. Spec: one P2 reproduced and fixed, with the regression retained.Unaddressed findings
Merge Danger
Door: two-way
Revert restores the previous notification presentation.
Blast Radius: notifications
Direct issue notifications make an additional read of Ticket metadata during setup; failure remains best-effort, like the existing title read.
Built with codex · gpt-6.1-sol · high