Skip to content

Name the owning Command in Run notification emails - #979

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-709
Oct 21, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-709

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

Run notification bodies name the owning Command and Pickup's dispatched run kind. Subjects, Architect/Security notifications, single-owner delivery and quiet skips keep their existing behavior.

 Result:       <outcome>
 Issue:        <Issue URL>
 Title:        <title>
+Command:      Run | Spec run | Pickup run, which dispatched a Run | Pickup run, which dispatched a Spec run

Capture direct issue kind during notification setup so a failed Harness preflight still identifies a Spec run. Pickup retains the refreshed Ready issue's kind. Update the Run notification glossary entry.

Closes #709

Evidence

  • Before: targeted Run, Spec run and Pickup notification assertions failed on missing/incorrect Command: text.
    After: the full suite passes, including all 123 notification and Pickup tests.
  • Before: the Spec review's exact cargo test --test run_notification a_spec_with_missing_harness_still_names_its_command -- --exact failed with Command: Run.
    After: the same command passes with Command: Spec run; its test is retained.
  • Final validation passed: cargo fmt --check, cargo clippy --all-targets -- -D warnings, and the full cargo test suite.

Test seams

  • CLI invocation → captured Resend request, using the existing Scenario and Resend stand-in: direct Run/Spec run, Merge run, Pickup dispatch, and failed Spec preflight.
  • Existing notification body expectations are updated at their current seam.

Review coverage

Independent Standards and Spec reviews used main as the fixed point and inspected all seven final changed files. No changed file was left unread by either axis; no generated-output exclusions. Standards: no findings. Spec: one P2 reproduced and fixed, with the regression retained.

Unaddressed findings

  • Standards: None.
  • Spec: None.

Merge Danger

Door: two-way

Revert restores the previous notification presentation.

Blast Radius: notifications

Direct issue notifications make an additional read of Ticket metadata during setup; failure remains best-effort, like the existing title read.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 86688fb into main Oct 21, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-709 branch October 21, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

note what kind of run it was in notice email (architect, pickup, manual, etc)

1 participant