Repository navigation
Wait for each Console page to load before reading its styles - #970
Merged
Merged
Conversation
The accounts browser test clicked the Console log and Account links and read the body's background colour without waiting for the next page's load. When the stylesheet arrived late it read rgba(0, 0, 0, 0), as on PR #943's console-test run 39642022517. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The accounts browser test read the body's background colour right after clicking a link, before the next page's stylesheet had applied. It now waits for each page's
loadthe way its sign-in and sign-out steps already do.test("sign-in and sign-out work on a phone without JavaScript …") - click "Console log" + click "Console log" and wait for /console-log to load wait for "owner@example.test · sign-in" assert body background is rgb(18, 18, 20) - click "Account" + click "Account" and wait for /account to load assert body background is rgb(18, 18, 20)Evidence
Before:
console-testfailed on PR Rename Replay to Experiment and Grade to Score, and add eval terms #943 (run 39642022517) with'rgba(0, 0, 0, 0)' !== 'rgb(18, 18, 20)'ataccounts.test.cjs:64. A rerun with no changes passed.After: I made local copies of the test that delay
/assets/console.cssby 300 ms:The full Console suite passes locally: 37 of 37.
Merge Danger
Door: two-way
Blast Radius: test-only
Only
console/tests/accounts.test.cjschanges. No product code changes.🤖 Generated with Claude Code