Skip to content

Show thirdshift cron jobs in the Console - #962

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-953
Oct 21, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-953

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

Console
└── 8 Cron jobs (/cronjobs; g then j)
    └── schedule + escaped command from this account's crontab
CLI
└── thirdshift cronjobs [--json] — same inventory

Shows active entries containing a literal thirdshift word or executable path. Reads crontab -l without changing schedules or starting work. Empty crontabs and read failures produce distinct results. Other accounts, system crontabs and script contents are outside this inventory.

Closes #953

Evidence

  • Before: cargo test --test console cronjobs::cronjobs_pairs_cli_and_console_without_running_scheduled_commands -- --exact failed because cronjobs was not a command.
    After: all three cronjobs integration tests pass, covering CLI/Console parity, escaping, empty/read-failure states and cron's command/stdin separator.
  • Before: the Spec review's exact Python reproduction returned [] for /usr/local/bin/thirdshift%stdin; its retained regression also failed.
    After: the same reproduction passes; cronjobs::cronjobs_respects_crons_command_and_stdin_separator includes the job, excludes matches found only in stdin, and preserves the full displayed entry.
  • cd console && npm test: all 36 browser tests pass, including Cron jobs link/keyboard navigation, reload and 390 px layout.
  • cargo test: full Rust suite passes.
  • cargo check --all-targets, cargo clippy --all-targets -- -D warnings, and cargo fmt --check: pass.

Test seams

  • The binary's cronjobs [--json] and Console HTTP routes, replacing crontab -l only at the operating system process boundary.
  • Browser navigation, rendered command text, reload and phone layout.

Merge Danger

Door: two-way

No persistent format or configuration changes.

Blast Radius: Console

Adds a read-only crontab inventory and its CLI equivalent; existing scheduling remains with the operating system.

Unaddressed findings

Standards

None.

Spec

None. The one P3 finding was reproduced, fixed in 0f75d1c, and verified by the reviewer on follow-up.

Security review outcome

  • Security review incomplete: session failed, ended early or omitted a valid final line; see Session log

Review coverage

Reviewed against main (7a9331c). Standards: 0 findings. Spec: 1 finding, resolved. Both independent reviewers read all 13 changed files and reviewed the follow-up. Unread changed files: none under either axis. Generated-output exclusions: none.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 596d12a into main Oct 21, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-953 branch October 21, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

show thirdshift cronjobs in thirdshift console web ui

1 participant