Repository navigation
Reject malformed Console sign-in addresses - #951
Merged
Merged
Conversation
This was referenced Oct 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setup asks again; a User config containing an invalid entry fails to load.
Empty comma-separated items, including trailing commas, are rejected and documented.
Closes #947
Evidence
cargo test --test user_config invalid_console_sign_in_entries_stop_loading_and_name_the_entryfailed: the reported two-@entry returned success instead of rejection.After: the regression passes; all 15 User config tests, 10 Console Setup tests and 24 terminal Setup tests pass.
cargo test,cargo check,cargo fmt --check, andcargo clippy --all-targets -- -D warningsall passed.Test seams
Review coverage
Independent Standards and Spec reviews against
main: no findings. Both reviewedall four changed files:
console/README.md,src/config/console.rs,src/setup/console_tests.rs, andtests/user_config.rs.Unread changed files: none. Generated-output exclusions: none.
Unaddressed findings
Standards: None.
Spec: None.
Security review outcome
Merge Danger
Door: two-way
Reversible validation change. Existing malformed sign-in entries now prevent User
config loading and must be corrected manually; the error names the entry.
Blast Radius: configuration
Built with codex · gpt-6.1-sol · high