Skip to content

Reject malformed Console sign-in addresses - #951

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-947
Oct 21, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-947

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

 Console sign-in list validation
-contains @ and no whitespace
+exactly one @, nonempty local part, dotted domain without edge dots, no whitespace
+name the rejected entry in the error

Setup asks again; a User config containing an invalid entry fails to load.
Empty comma-separated items, including trailing commas, are rejected and documented.

Closes #947

Evidence

  • Before: cargo test --test user_config invalid_console_sign_in_entries_stop_loading_and_name_the_entry failed: the reported two-@ entry returned success instead of rejection.
    After: the regression passes; all 15 User config tests, 10 Console Setup tests and 24 terminal Setup tests pass.
  • Validation: full cargo test, cargo check, cargo fmt --check, and cargo clippy --all-targets -- -D warnings all passed.

Test seams

  • User config loading through the CLI: reject invalid Console sign-in entries before starting work.
  • Setup through its existing Outside script: print entry-naming errors, ask again, and write only after valid answers.

Review coverage

Independent Standards and Spec reviews against main: no findings. Both reviewed
all four changed files: console/README.md, src/config/console.rs,
src/setup/console_tests.rs, and tests/user_config.rs.
Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

Standards: None.

Spec: None.

Security review outcome

  • Security review incomplete: session failed, ended early or omitted a valid final line; see Session log

Merge Danger

Door: two-way

Reversible validation change. Existing malformed sign-in entries now prevent User
config loading and must be corrected manually; the error names the entry.

Blast Radius: configuration

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 7a9331c into main Oct 21, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-947 branch October 21, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console sign-in list accepts non-addresses like a@b@c.com

1 participant