Skip to content

Add History, Security, the peek and Console keyboard navigation - #856

Merged
JacobStephens2 merged 4 commits into
issue-776from
issue-820
Oct 20, 2026
Merged

JacobStephens2 merged 4 commits into
issue-776from
issue-820

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

Console
  1 Inbox
  5 History → ended Commands, outcome/repository filters
  6 Logs → shared inventory and live conversation reader
  7 Security → findings and sessions
  row → peek (show) → full log (logs)

Closes #820

Test seams: the thirdshift console --no-sign-in binary over HTTP with fixture Command records and logs; the same served Console in Playwright; status --all --json, show --json and logs for parity; a real Security run through the existing fake Harness/GitHub integration harness for retained findings.

History preserves individual Commands even when the Inbox collapses repeated failures, and reaches Activity and Session logs without records. Exact record selectors distinguish dispatched Runs and older Commands on the same issue. Security finding metadata is retained locally and shared with the CLI. Unbuilt pages remain absent.

Evidence

  • Before: cargo test --test console history_keeps_every_ended_command_in_time_order_and_filters failed because History was absent; the Security page and exact-selector regressions also failed before implementation. The real Security-run test found security_findings[0].title was null.
    After: all 13 combined Console HTTP tests and 11 Playwright tests pass; the real Security-run test passes. Playwright verifies keys, page URLs/reload, filters, Security sessions, wide-screen peek and the 390 px bottom sheet, plus unchanged list nodes during selection and the upstream live reader. cargo clippy --all-targets -- -D warnings and both route-parity tests pass.

  • Review regression: the Spec reviewer's exact focused Playwright command failed before the fix because Enter on a focused Session link opened the Command log. The same command passes after preserving native link/button activation, and its test is retained.

  • Full validation: cargo test --locked passed before upstream reconciliation (2 existing ignored unit tests). After merging Session log and Command log views, and the Logs page #819, the combined Console HTTP tests, all 11 Playwright tests, the original focused review reproduction, route-parity tests and Clippy pass.

Merge Danger

Door: two-way

Existing records remain readable; finding metadata is an optional additive field.

Blast Radius: Console

Shared show/logs selection also accepts exact retained paths. No new dependencies.

Review coverage

Initial review fixed point: fetched issue-776 at 37b87debc3f73ad71b338af8cceb4028dc6351f9. After #819 landed during validation, merged and reviewed again against fetched issue-776 at b557e4d20060da130b768005f4238273acf73bcf. The merged Logs page and reader use the same page keys and navigation; upstream child-log and streaming-restart regressions are retained.

Standards: 1 P3 design finding, addressed. Spec: 1 P2 keyboard finding, reproduced and fixed. Fresh independent reviewers covered all 23 final changed files after reconciliation, with no new findings. Unread changed files: none on either axis. Generated-output exclusions: none. Reports with each final files-read list are retained in .thirdshift-review-TjDIka/standards.md and spec.md.

Unaddressed findings

Standards

None. The page title and CLI description are now chosen together.

Spec

None. The focused Session-link finding was reproduced, fixed and retained as a regression test.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 5af85a5 into issue-776 Oct 20, 2026
19 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-820 branch October 20, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant