Repository navigation
Add History, Security, the peek and Console keyboard navigation - #856
Merged
Merged
Conversation
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #820
Test seams: the
thirdshift console --no-sign-inbinary over HTTP with fixture Command records and logs; the same served Console in Playwright;status --all --json,show --jsonandlogsfor parity; a real Security run through the existing fake Harness/GitHub integration harness for retained findings.History preserves individual Commands even when the Inbox collapses repeated failures, and reaches Activity and Session logs without records. Exact record selectors distinguish dispatched Runs and older Commands on the same issue. Security finding metadata is retained locally and shared with the CLI. Unbuilt pages remain absent.
Evidence
Before:
cargo test --test console history_keeps_every_ended_command_in_time_order_and_filtersfailed because History was absent; the Security page and exact-selector regressions also failed before implementation. The real Security-run test foundsecurity_findings[0].titlewas null.After: all 13 combined Console HTTP tests and 11 Playwright tests pass; the real Security-run test passes. Playwright verifies keys, page URLs/reload, filters, Security sessions, wide-screen peek and the 390 px bottom sheet, plus unchanged list nodes during selection and the upstream live reader.
cargo clippy --all-targets -- -D warningsand both route-parity tests pass.Review regression: the Spec reviewer's exact focused Playwright command failed before the fix because Enter on a focused Session link opened the Command log. The same command passes after preserving native link/button activation, and its test is retained.
Full validation:
cargo test --lockedpassed before upstream reconciliation (2 existing ignored unit tests). After merging Session log and Command log views, and the Logs page #819, the combined Console HTTP tests, all 11 Playwright tests, the original focused review reproduction, route-parity tests and Clippy pass.Merge Danger
Door: two-way
Existing records remain readable; finding metadata is an optional additive field.
Blast Radius: Console
Shared
show/logsselection also accepts exact retained paths. No new dependencies.Review coverage
Initial review fixed point: fetched
issue-776at37b87debc3f73ad71b338af8cceb4028dc6351f9. After #819 landed during validation, merged and reviewed again against fetchedissue-776atb557e4d20060da130b768005f4238273acf73bcf. The merged Logs page and reader use the same page keys and navigation; upstream child-log and streaming-restart regressions are retained.Standards: 1 P3 design finding, addressed. Spec: 1 P2 keyboard finding, reproduced and fixed. Fresh independent reviewers covered all 23 final changed files after reconciliation, with no new findings. Unread changed files: none on either axis. Generated-output exclusions: none. Reports with each final files-read list are retained in
.thirdshift-review-TjDIka/standards.mdandspec.md.Unaddressed findings
Standards
None. The page title and CLI description are now chosen together.
Spec
None. The focused Session-link finding was reproduced, fixed and retained as a regression test.
Built with codex · gpt-6.1-sol · high