Repository navigation
Add Console log inventory and live conversation readers - #853
Merged
Merged
Conversation
JacobStephens2
marked this pull request as ready for review
October 20, 2026 00:41
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Console can list and read current-layout Command and Session logs, including a Spec run's child Runs. Live readers append rendered HTML from byte offsets and preserve the reader's open tool groups and follow choice.
Closes #819
Evidence
After: the shared
--commandfilter and focused CLI/HTTP parity regression pass.After: streams close on executable replacement; the retained regression passes.
cargo test --test console: 8 passed, covering both harnesses, unknown events, escaping, current-layout inventory, child logs, byte offsets and updates.cd console && npm test: 5 passed, including live appends without redraw, tool folding across batches, partial lines, reconnect offsets, following and a 390 px viewport.cargo test --locked: passed (full Rust suite; 2 pre-existing ignored unit tests).cargo check,cargo fmt --check, andcargo clippy --all-targets -- -D warnings: passed.Merge Danger
Door: two-way
Read-only Console views and additive CLI log selectors; no persisted log migration.
Blast Radius: logs
Console log presentation and following; current-layout inventory includes Security logs under the Console's existing access gate.
Test seams
logsCLI and Console HTTP pages, using real filesystem log fixtures.Unaddressed findings
Standards
None. The documented CLI parity violation and both heuristic findings (duplicated line framing and log-kind display strings controlling behavior) are addressed and verified in the follow-up review.
Spec
src/console/conversation.rs:109now renders the complete event through a visible fallback. The official FileUpdateChange schema records onlypathandkind, with no old/new text. This refutes the initial fixture's assumption that the reader receiveschanges[].diff; it does not refute the requested diff requirement. The reviewer's exact command failed as reported, andpython3 console/reproductions/codex-edit-diff.pykeeps that failing requirement reproduction. Capturing genuine patch evidence changes Session log retention beyond this reader; #854 asks the Day shift to choose capture or explicitly accept the specified plain fallback. No current files or historical patches are guessed.Review coverage
Independent Standards and Spec reviews used
issue-776, pinned to its fetched remote tip37b87debc3f73ad71b338af8cceb4028dc6351f9. Both reviewers inspected all 25 changed files, including the final fix hunks and the retained reproduction. Unread changed files: none under either axis. Generated-output exclusions: none.Built with codex · gpt-6.1-sol · high