Skip to content

Show the machine’s Inbox in thirdshift status - #848

Merged
JacobStephens2 merged 3 commits into
issue-776from
issue-816
Oct 19, 2026
Merged

JacobStephens2 merged 3 commits into
issue-776from
issue-816

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

thirdshift status now shows the machine's Inbox. Closes #816.

local Command records + history + health
  → Needs you → Ready for review → Landing → Working → Done → Resolved
  → --all adds History

Ended problems clear after a later local start on the same issue or inbox.days (default 7). Same-cause failures show one item with a count. JSON carries the groups, Needs you kinds and Landing references for the Console.

Evidence

  • Before: cargo test --test status inbox_groups_ended_commands_and_adds_only_old_history_with_all -- --exact failed: groups were missing and older completions were omitted.
    After: the fixture tests cover group order, live Silent/Slow precedence, Landing references, expiry, later starts, Stop triage, finding decisions and failure collapse.
  • Validation: cargo test, cargo clippy --all-targets -- -D warnings, cargo fmt --check, and all 20 site browser tests (npm test --prefix site) pass.
  • Full-suite validation caught a nested-row prefix regression; the final text keeps Run … at the start and places the state word after the subject. The existing Architect-run nesting test and all 26 status tests pass.
  • Test seams: the thirdshift binary's status text and JSON with fixture Command records; existing Security-run binary scenarios verify the writer records waiting findings and empty audits correctly.

Unaddressed findings

Standards

None. Addressed the cause-normalization duplication and reproduced retention overflow; kept a binary regression for the overflow. The exact overflow command failed before the fix (binary exit 101) and passed afterward.

Spec

None. Ready for review rows now include their captured PR URL. The reviewer's exact fixture reproduction failed before the fix and passed afterward; the text assertion remains in the status tests.

Review coverage

Independent Standards and Spec reviews compared against issue-776 at 4447009; both follow-ups verified the fixes at b375b7d. Each axis read all 16 changed files, including the generated HTML. The subsequent row-prefix adjustment in src/logs/status.rs and tests/status.rs was validated through the existing binary tests. Unread changed files: none. Generated-output exclusions: none.

Merge Danger

Door: two-way

Computed local observations, with a backward-compatible waiting flag on new Command records. Rollback restores the previous status view.

Blast Radius: status

Changes status ordering, history visibility and additive JSON fields; no GitHub reads or writes from status.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 87ca83b into issue-776 Oct 19, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-816 branch October 19, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant