Repository navigation
Show the machine’s Inbox in thirdshift status - #848
Merged
Merged
Conversation
This was referenced Oct 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thirdshift statusnow shows the machine's Inbox. Closes #816.Ended problems clear after a later local start on the same issue or
inbox.days(default 7). Same-cause failures show one item with a count. JSON carries the groups, Needs you kinds and Landing references for the Console.Evidence
cargo test --test status inbox_groups_ended_commands_and_adds_only_old_history_with_all -- --exactfailed: groups were missing and older completions were omitted.After: the fixture tests cover group order, live Silent/Slow precedence, Landing references, expiry, later starts, Stop triage, finding decisions and failure collapse.
cargo test,cargo clippy --all-targets -- -D warnings,cargo fmt --check, and all 20 site browser tests (npm test --prefix site) pass.Run …at the start and places the state word after the subject. The existing Architect-run nesting test and all 26 status tests pass.thirdshiftbinary'sstatustext and JSON with fixture Command records; existing Security-run binary scenarios verify the writer records waiting findings and empty audits correctly.Unaddressed findings
Standards
None. Addressed the cause-normalization duplication and reproduced retention overflow; kept a binary regression for the overflow. The exact overflow command failed before the fix (binary exit 101) and passed afterward.
Spec
None. Ready for review rows now include their captured PR URL. The reviewer's exact fixture reproduction failed before the fix and passed afterward; the text assertion remains in the status tests.
Review coverage
Independent Standards and Spec reviews compared against
issue-776at4447009; both follow-ups verified the fixes atb375b7d. Each axis read all 16 changed files, including the generated HTML. The subsequent row-prefix adjustment insrc/logs/status.rsandtests/status.rswas validated through the existing binary tests. Unread changed files: none. Generated-output exclusions: none.Merge Danger
Door: two-way
Computed local observations, with a backward-compatible waiting flag on new Command records. Rollback restores the previous status view.
Blast Radius: status
Changes status ordering, history visibility and additive JSON fields; no GitHub reads or writes from status.
Built with codex · gpt-6.1-sol · high