[JacobStephens2]

Summary

CI watch and Self-merge keep the Command log growing while they wait. User config logs.waiting_line_minutes defaults to 5; Setup writes and preserves it.

pending observation
  state changed OR waiting interval elapsed → write waiting line
  unchanged before interval elapsed        → keep polling

CI watch reports running/total checks; Self-merge reports GitHub calculating mergeability.

Test seams

• The thirdshift binary, with User config input and fake GitHub observations; assert stderr and retained Command log output during CI watch and Self-merge.
• UserConfig::parse and UserConfigDocument: interval defaults, validation and Setup preservation.

Evidence

• Before: cargo test --test ci unchanged_running_checks_keep_writing_waiting_lines_to_the_command_log -- --exact failed: only one line appeared while checks stayed running. The Self-merge regression failed because mergeability polling wrote no waiting lines.
  After: both binary/fake-GitHub regressions pass, verifying repeated output also appears in the retained Command log. Existing CI count-change tests still pass.
• cargo check, cargo fmt --check, cargo clippy --all-targets -- -D warnings passed.
• Focused suites passed: config (32), CI (24), Command logs (12), Setup (22).
• Full cargo test passed (including 1,063 unit tests; two existing tests ignored).

Merge Danger

Door: two-way

Blast Radius: logging

Changes waiting-line frequency and adds a validated User config setting; existing merge and CI gates remain in force.

Unaddressed findings

Standards

None. The Standards reviewer reported 0 findings.

Spec

None. The Spec reviewer reported 0 findings.

Review coverage

Both reviewers read every changed file (11 total). Changed files left unread: none on either axis. Generated-output exclusions: none.

Closes #814

Built with codex · gpt-6.1-sol · high