Repository navigation
Wait for main CI before starting a release - #791
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #765
Evidence
cargo test --test release an_unfinished_ci_run_on_main_is_watched_before_releasing -- --exactfailed withCI on main ... is in_progress, not finished.After: the same test passes through merging and tagging.
an_unfinished_ci_run_on_main_that_does_not_succeed_pushes_nothingverifies that CI ending in failure, cancellation, timeout, or skip leaves remote refs and PRs unchanged after waiting.cargo test: 1,944 passed, 2 ignored before upstream reconciliation. Reconciliation retained the same runtime implementation; its fixture, assertion, and manual changes were revalidated below.cargo test --test release: 61 passed.cargo check --all-targets,cargo clippy --all-targets -- -D warnings,cargo fmt --check, andbash -n scripts/release.sh: passed.cd site && npm test: generated manual freshness check and 13 browser tests passed.python3 -m unittest discover -s scripts -p 'test_*.py': 1 passed.Test seams
scripts/release.sh <version>against a real local git origin and fake GitHub/Harness CLIs: default-branch CI completion gates release publication.Review coverage
Independent Standards and Spec reviews against
maineach read all four changed files:scripts/release.sh,tests/release.rs,docs/guide.md, andsite/docs/index.html. Both axes reported no findings. Unread changed files: none. Generated-output exclusions: none; both reviewers inspected the generated HTML change.Unaddressed findings
ecec64aagainst pinned merge baseb3d2f1ae941dd464f35910d3e617ce2795a53c40found no introduced security findings; ten sandboxed local CI-gate checks passed.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Reverting restores immediate refusal for unfinished main CI.
Blast Radius: releases
Fresh release invocations can now wait without an overall timeout for main CI, using the existing polling interval. Publication still requires successful CI on the selected commit.
Built with codex · gpt-6.1-sol · high
CI notes
b8799b0was cancelled after the newerecec64arun started at 04:50:18 UTC, consistent with the unchanged PR concurrency policy: Linux and all four macOS shards report cancellation, the macOS aggregate reportsRESULT: cancelled, and all 61 release tests (including both changed tests) had already passed; this branch does not change the CI workflow or the cancelled macOS tests.ecec64a: fullcargo testpassed (1,944 passed, 0 failed, 2 existing ignored), including all 61 release tests; macOS execution is unavailable on this Linux host.