Repository navigation
Add an engineer's guide to thirdshift's process - #789
Merged
Merged
Conversation
This was referenced Oct 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
/how-it-works/, linked from the homepage, with a progressive engineer's guide and six responsive HTML/CSS diagrams. The page stays readable without JavaScript and follows the existing site's visual language.Closes #88
Evidence
Before:
cd site && node --test --test-name-pattern='the homepage leads' tests/pages.test.cjsfailed waiting for the missing homepage guide link.After: the same test passes and follows the homepage link through the seven ordered explanations.
The diagram layout checks exposed header overflow at 320px, 390px and 768px; removing the guide header's inherited rotation fixed it. All seven guide checks now pass, including section navigation, Repair return links, prompt deep links and layouts at 320/390/768/1280px with JavaScript disabled.
cd site && npm test: all 11 browser tests pass, including the existing Prompts and skills tests. Inspected desktop and mobile screenshots.cargo check,cargo fmt --check, andcargo clippy --all-targets -- -D warnings: pass.cargo test: the full Rust unit and integration suite passes (two ignored unit tests).Independent verification of published
22aa70b: all 11 browser tests passed, as didcargo checkandcargo fmt --check. All 900 Rust integration tests passed across 48 suites on byte-identical Rust source and fixtures. The independent unit run had 1042 passes, 2 ignored and one failure insession::execution_tests::partial_stdout_is_reported_after_log_failure_with_a_blocked_prompt(prompt-write BrokenPipe instead of the expected log-write BrokenPipe); its exact rerun passed:cargo test --bin thirdshift session::execution_tests::partial_stdout_is_reported_after_log_failure_with_a_blocked_prompt -- --exact --nocapture.Test seams
Review coverage
Independent Standards and Spec reviews use
git diff main...HEADwithmainatd5694638afb600360ddde6091d2089d2edbb655c. Each reviewed all four changed files, including the renamed browser test file. No generated-output exclusions. Unread changed files: none on either axis.Unaddressed findings
Standards
None.
Spec
None.
Security
None. Guidance-mode security review of HEAD
22aa70bagainst pinned merge based5694638afb600360ddde6091d2089d2edbb655ccovered all four changed files, shared styles and JavaScript, browser-test server and runner, CI, and static deployment configuration. Applied the relevant injection, client-side rendering/navigation, resource/file handling, secrets, and supply-chain guidance alongside the unattended-session trust model in README and ADR-0013. The guide contains fixed HTML/CSS and fixed links, with no scripts, forms, or user-controlled rendering; the homepage additions are fixed links. The test routing change retains the existing loopback listener, and deployment serves static files. No introduced security finding or candidate required a proof-of-concept test. No target code or tests were executed, and no source changes were made during this review.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Static documentation and browser tests; revert to remove the guide. No runtime or data changes.
Blast Radius: site
Adds a page and two homepage links. Diagram styles load only on the guide; the shared browser test runner continues to exercise the Prompts and skills page.
Built with codex · gpt-6.1-sol · high