Repository navigation
Share card and homepage links - #78
Merged
Merged
Conversation
The card is the home page's headline over its press line, rendered at 1200x630 from the page itself by docs/share-card/render.mjs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tle and description, drop the canonical link Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/prompts/doesn't exist yet, so only the home page is tagged. The README is untouched.Evidence
Card (
site/share-card.png, 1200×630):cargo test --test share_card: 3 failed (the home page has no twitter:card, noog:type, …)After:
cargo test --test share_card: 4 passed.cargo test --test packaging: 2 passed. The fullcargo testpasses.Merge Danger
Door: two-way
Tags, an image and a manifest field. All of it reverts cleanly. Platforms that already scraped the page may keep a cached card until they re-scrape.
Blast Radius: small
The home page's rendering is unchanged, since the tags live only in
<head>. The crates.io page links to thirdshift.app from the next published release.Unaddressed findings
Standards
site()duplicatesdeploy_dir()'sCARGO_MANIFEST_DIRwalk: only two copies exist, so it isn't worth a shared helper intests/support/yet.meta()takes a free-formattributestring: its only callers are theog()andtwitter()wrappers, which fix the value.png_size's bare IHDR byte offsets, and 1200×630 written in both the test and the render script: the doc comment names the chunk. The test is the check that catches the two drifting apart.Spec
NODE_PATH, as the script's header says.tests/share_card.rswasn't asked for: kept, because it is how the acceptance criteria are checked.meta()depends on attribute order: the site's tags are hand-written in one shape. A reorder fails loudly rather than passing silently.Closes #69
🤖 Generated with Claude Code