Repository navigation
Record Passes and show idle Passes in status - #779
Merged
Merged
Conversation
This was referenced Oct 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the version 1 JSON fields for Passes, dispatched work and idle reasons.
Closes #770
Evidence
status_names_a_live_architecture_review_by_kind_and_command_stampfailed becausecommandswas empty;status_nests_the_architect_plans_run_or_spec_run_under_its_passfailed becausedispatchedwas absent;status_tracks_security_stages_and_nests_the_dispatched_fixfailed because the Security audit stage was absent;status_shows_each_idle_pass_until_its_own_kind_starts_workfailed becauseidle_passeswas absent.After: all four regression tests pass through the existing fake Harness and GitHub.
cargo test --test architect_run a_dispatch_that_fails_its_launch_checks_still_has_a_record -- --exact, failed with zero dispatched records after a Git identity preflight failure.After: the same command passes; the retained test checks the dispatched issue and failed outcome.
cargo nextest run --test-threads 8 --no-fail-fast: 1,886 passed, 2 skipped across 46 binaries.cargo fmt -- --check,cargo check --all-targetsandcargo clippy --all-targets -- -D warnings: passed. The updated command-log suite also passed all 11 tests.Seams under test
thirdshiftbinary with existing fake Harness/GitHub:statustext/JSON during live Pass stages, nested Run and Spec run dispatches, retained Command records, and latest-per-kind idle reasons.Review coverage
Independent Standards and Spec reviews against
issue-711, pinned atdc99a350f295d12ecee683f0e183bc1bddde7d63.Standards: one Duplicated Code heuristic addressed by shared retained-record loading. Spec: one P2 addressed by recording dispatch before fallible launch checks. Both reviewers inspected all 13 files changed through
22868a4. Changed file left unread by both Standards and Spec:tests/command_logs.rs, subsequently updated to exclude retained Command records from its log-file listing helper after two old exact-list assertions failed. Generated-output exclusions: none. Final reports, including each axis's files-read list and this coverage gap, are retained in.thirdshift-review-qj6BfL/standards.mdand.thirdshift-review-qj6BfL/spec.mdin the implementation worktree.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Revertible recording and status changes; retained records remain version 1.
Blast Radius: status
Adds nullable issues and nested dispatches to the documented JSON, plus idle reasons from Activity logs. Recording failures remain warnings.
Built with codex · gpt-6.1-sol · high