Skip to content

Record Passes and show idle Passes in status - #779

Merged
JacobStephens2 merged 3 commits into
issue-711from
issue-770
Oct 18, 2026
Merged

JacobStephens2 merged 3 commits into
issue-711from
issue-770

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Pass (Architect, Pickup or Security run)
  ├─ own stages: Architecture review; Security audit / reproduction / fix publishing
  └─ dispatched Run or Spec run, with its own stages and outcome
status
  ├─ Passes named by kind and Command log stamp
  └─ idle Passes ← latest Activity log line per repository and kind

Documents the version 1 JSON fields for Passes, dispatched work and idle reasons.

Closes #770

Evidence

  • Before: status_names_a_live_architecture_review_by_kind_and_command_stamp failed because commands was empty; status_nests_the_architect_plans_run_or_spec_run_under_its_pass failed because dispatched was absent; status_tracks_security_stages_and_nests_the_dispatched_fix failed because the Security audit stage was absent; status_shows_each_idle_pass_until_its_own_kind_starts_work failed because idle_passes was absent.
    After: all four regression tests pass through the existing fake Harness and GitHub.
  • Before: the Spec review's exact reproducer, cargo test --test architect_run a_dispatch_that_fails_its_launch_checks_still_has_a_record -- --exact, failed with zero dispatched records after a Git identity preflight failure.
    After: the same command passes; the retained test checks the dispatched issue and failed outcome.
  • cargo nextest run --test-threads 8 --no-fail-fast: 1,886 passed, 2 skipped across 46 binaries.
  • cargo fmt -- --check, cargo check --all-targets and cargo clippy --all-targets -- -D warnings: passed. The updated command-log suite also passed all 11 tests.

Seams under test

  • The thirdshift binary with existing fake Harness/GitHub: status text/JSON during live Pass stages, nested Run and Spec run dispatches, retained Command records, and latest-per-kind idle reasons.
  • Existing recorder tests continue to cover warning suppression and process identity.

Review coverage

Independent Standards and Spec reviews against issue-711, pinned at dc99a350f295d12ecee683f0e183bc1bddde7d63.

Standards: one Duplicated Code heuristic addressed by shared retained-record loading. Spec: one P2 addressed by recording dispatch before fallible launch checks. Both reviewers inspected all 13 files changed through 22868a4. Changed file left unread by both Standards and Spec: tests/command_logs.rs, subsequently updated to exclude retained Command records from its log-file listing helper after two old exact-list assertions failed. Generated-output exclusions: none. Final reports, including each axis's files-read list and this coverage gap, are retained in .thirdshift-review-qj6BfL/standards.md and .thirdshift-review-qj6BfL/spec.md in the implementation worktree.

Unaddressed findings

Standards

None.

Spec

None.

Merge Danger

Door: two-way

Revertible recording and status changes; retained records remain version 1.

Blast Radius: status

Adds nullable issues and nested dispatches to the documented JSON, plus idle reasons from Activity logs. Recording failures remain warnings.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 1b7e644 into issue-711 Oct 18, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-770 branch October 18, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant