Repository navigation
Prefer structured edit tools in source-editing Factory sessions - #763
Merged
Merged
Conversation
JacobStephens2
marked this pull request as draft
October 17, 2026 17:11
JacobStephens2
marked this pull request as ready for review
October 17, 2026 17:13
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One shared paragraph in
src/prompt.rscovers implementation, review and Repair sessions, including permitted exploratory edits. Regenerated the Markdown prompt examples and site's generated fragment from their sources.Closes #734
Evidence
cargo test --bin thirdshift source_editing_sessions_prefer_available_structured_tools_and_allow_scoped_scriptsfailed because the fresh Session prompt lacked the editing preference.After: The same test passes across all nine source-editing prompt variants; all three prompt tests pass, including exclusion checks for read-only sessions and Resumes that retain their original guidance.
values.push(7)statements, contextualapply_patchchanged only the intended function topush(8). Before, its assertion failed ([7]versus[8]); after, compilation and both assertions passed, confirming the unrelated function still returned[7]. The Spec reviewer independently reran the fixture. This demonstrates this session's small edit; historical Tickets keep their repository from the sub-issue graph to the Run #672/E0308 evidence remains attributed to the retrospective, with no claim of measured productivity gains.cargo check --all-targets,cargo fmt --check, andcargo clippy --all-targets -- -D warningspassed.UPDATE_PROMPTS=1 cargo test prompts_pageregenerated artifacts; all 11 rendering/reference checks pass on the reconciled branch, including the other session's matrix over all 15 prompt variants.cargo test --test fresh_run --test ci --test mergeablepassed all 52 integration tests.cargo testsuite passed oned46f7c. Reconciliation with the concurrently published branch adds only a test insrc/prompts_page.rs; production code and generated artifacts are identical to that full-suite run. Both structured-edit tests, all 11 prompt-reference checks, formatting and Clippy were rerun successfully after reconciliation.cd site && npm testpassed all four browser tests against the regenerated page.Test seams
src/prompt.rs's public prompt functions, including source-editing and read-only sessions.prompts_pageartifact checks.apply_patchtool, verified by the resulting diff and fixture assertions.Review coverage
Independent Standards and Spec reviews against
mainfound no findings. Both axes read every changed file (17 each); changed files left unread: none. Each report and its final files-read list is retained in the session's requested review directory.Unaddressed findings
ee154e853b9917bb9a84bb65248c0d57640ade14...d0f548dfbb1279cb4351a6aaf2dbf5c1f10f23f7covered all 17 changed files and supporting prompt assembly, Harness argument handling and HTML/Markdown rendering, using the relevant attack-class guidance and trust-model ADRs. No introduced Security findings. In an isolated offline sandbox,cargo test --offline --locked --bin thirdshift prompts_page -- --test-threads=2passed 11 tests andcargo test --offline --locked --bin thirdshift prompt::tests -- --test-threads=2passed 3 tests. No source changes were needed.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the paragraph and regenerate the references to restore the prior guidance.
Blast Radius: Sessions
Changes source-editing instructions across Harnesses. Adds no host dependency or installation step.
Built with codex · gpt-6.1-sol · high