Repository navigation
Add domain-to-code navigation and bounded agent reading - #759
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the separate navigation index, bounded-reading guidance, accurate generation instructions for both prompt outputs, and links to the existing fake-test layout and site-test setup. Keep glossary definitions and domain behavior unchanged.
Closes #728
Evidence
cargo test prompts_pagefailed: the site fragment contained stale Factory skill instructions (9 passed, 1 failed).After:
UPDATE_PROMPTS=1 cargo test prompts_page, thencargo test prompts_page: all 10 passed. A second regeneration changed none of the 17 prompt-documentation files/page; surrounding hand-written HTML stayed unchanged.cd site && npm ci && npx playwright install --with-deps chromium && npm test: all 4 browser tests passed using the existing setup instructions.cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings: passed.cargo test: passed (two existing ignored unit tests).Validation seams: existing prompt-documentation generation checks and the site's browser interface. Documentation checks use representative term-to-owner lookups and local link/path resolution.
Review coverage
Independent Standards and Spec reviewers checked
main...HEAD, including all seven changed files and the generated page's changed hunks. Standards: one P3 instruction-duplication finding, fixed in228f0d8and verified by the reviewer. Spec: no findings. Both reviewers checked the final correction. Generated-output exclusions: none. Unread changed files: none under either axis.Unaddressed findings
1c7c40afab8b45aab7527aa4cc6b91bfc9ca9f7fand supporting embedding/rendering code in one guidance session. All 10 prompt-page tests passed using the existing unit-test binary in an isolated, network-disabled sandbox. Static checks confirmed the three updated skills match their escaped published text and HTML structure/attributes and hand-written surrounding HTML are unchanged. No fixes required.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the documentation and regenerated site fragment together.
Blast Radius: guidance
Changes agent navigation and Factory review instructions, plus their published site text.
Built with codex · gpt-6.1-sol · high