Skip to content

Add domain-to-code navigation and bounded agent reading - #759

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-728
Oct 17, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-728

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

Issue terms → relevant CONTEXT entries → docs/code-navigation.md → owners/tests
Factory TDD / Architecture review → targeted domain lookup
Factory code review → changed hunks + supporting symbols
                    → explicit generated-output coverage and behavior checks

Add the separate navigation index, bounded-reading guidance, accurate generation instructions for both prompt outputs, and links to the existing fake-test layout and site-test setup. Keep glossary definitions and domain behavior unchanged.

Closes #728

Evidence

  • Before: cargo test prompts_page failed: the site fragment contained stale Factory skill instructions (9 passed, 1 failed).
    After: UPDATE_PROMPTS=1 cargo test prompts_page, then cargo test prompts_page: all 10 passed. A second regeneration changed none of the 17 prompt-documentation files/page; surrounding hand-written HTML stayed unchanged.
  • Validated all 63 code/test path occurrences and local links in the index; representative Claim, Ticket board and Run notification lookups resolve to their owning symbols.
  • cd site && npm ci && npx playwright install --with-deps chromium && npm test: all 4 browser tests passed using the existing setup instructions.
  • cargo check --all-targets, cargo fmt --check, cargo clippy --all-targets -- -D warnings: passed.
  • Full cargo test: passed (two existing ignored unit tests).

Validation seams: existing prompt-documentation generation checks and the site's browser interface. Documentation checks use representative term-to-owner lookups and local link/path resolution.

Review coverage

Independent Standards and Spec reviewers checked main...HEAD, including all seven changed files and the generated page's changed hunks. Standards: one P3 instruction-duplication finding, fixed in 228f0d8 and verified by the reviewer. Spec: no findings. Both reviewers checked the final correction. Generated-output exclusions: none. Unread changed files: none under either axis.

Unaddressed findings

  • Standards: None.
  • Spec: None.
  • Security: None. Reviewed all seven changed files against pinned merge base 1c7c40afab8b45aab7527aa4cc6b91bfc9ca9f7f and supporting embedding/rendering code in one guidance session. All 10 prompt-page tests passed using the existing unit-test binary in an isolated, network-disabled sandbox. Static checks confirmed the three updated skills match their escaped published text and HTML structure/attributes and hand-written surrounding HTML are unchanged. No fixes required.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Revert the documentation and regenerated site fragment together.

Blast Radius: guidance

Changes agent navigation and Factory review instructions, plus their published site text.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 5ac7005 into main Oct 17, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-728 branch October 17, 2026 14:15
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add code pointers and bounded reading guidance for repository navigation

1 participant