[JacobStephens2]

Summary

Issue-based completion notifications link the original issue immediately after the result, including failures and interruptions without a PR. Spec runs link their parent Spec; Pickup links the issue it dispatched.

 Result:       ready for review
+Issue:        https://github.com/acme/widgets/issues/7
 Pull request: https://github.com/acme/widgets/pull/1

Closes #704

Evidence

• Before: cargo test --test run_notification a_run_ready_for_review_sends_one_notification_to_the_address_given -- --exact failed: the body went straight from Result: to Pull request:.
  After: the same test passes with exactly one original-issue line in second position.
• Focused notification coverage: cargo test --test run_notification --test spec_run --test pickup_run — all 176 tests passed after the final merge, including parent Spec identity, Pickup dispatches, failure without a PR, interruption, review-required outcomes and original URL spelling.
• Validation: full cargo test passed at b4fd797. The final merge changes production source only in a comment; all 176 affected integration tests passed again at 874edee. Final cargo fmt --check, cargo check --all-targets, cargo clippy --all-targets -- -D warnings, and git diff --check main...HEAD passed.

Test seams

• CLI command completion → delivered Resend email, using real Git and external GitHub, Harness and Resend stand-ins: original issue identity, line order and uniqueness for direct Run, Spec run, Pickup Run and Pickup Spec, including failure without a PR and interruption.

Review

Reviewed against main (7c43d8b). Standards: two minor test duplication findings, both addressed. Spec: no findings. Fresh independent reviewers rechecked the final merged diff at 874edee and found no additional findings. Both axes read all six changed files; changed files left unread: none.

Security guidance review completed at 874edee against pinned merge base 7c43d8b19e194b664308269c20452d41eaa55688. Read all six changed files and supporting issue-identity, command-lifecycle, and email-serialization code, applying injection, disclosure, and message-boundary guidance and the relevant architecture decisions. No introduced Security findings were identified. No source changes were needed.

Sandboxed offline validation passed: cargo test --offline --locked --bin thirdshift notification:: -- --test-threads=2 (12 passed) and cargo test --offline --locked --test run_notification --test spec_run --test pickup_run -- --test-threads=2 (176 passed). Tests used isolated loopback stand-ins, no external network, read-only source/toolchain, an empty allowlisted environment, and bounded resources.

Unaddressed findings

• Standards: none.
• Spec: none.
• Security: none.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

The body-format change is reversible and changes no persisted state.

Blast Radius: notifications

Built with codex · gpt-6.1-sol · high

CI notes

• CI run 39031454572 was superseded by the run for 874edee: GitHub cancelled macOS shards 1 and 2 for a higher-priority request in the same concurrency group (shard 2 had already passed all 443 tests), so test-macos rejected the cancelled result; no test failure or branch fix was identified.
• Local validation at 874edee (Linux): cargo nextest run --partition hash:1/4 passed 464 tests; cargo nextest run --partition hash:2/4 passed 458 tests; cargo fmt --check and git diff --check passed. macOS validation is running in replacement CI run 39032429367.