Repository navigation
Clarify CI progress as checks listed so far - #751
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explain why dependent and matrix jobs can increase both counts. Keep identical repeated pairs quiet and retain existing Delivery gates.
Closes #289
Evidence
aed28d2:cargo nextest runpassed all 1,807 tests across 43 binaries (2 existing ignored tests skipped). Formatting,cargo check --all-targets, Clippy, all 27 CI unit tests, and all 23 CI integration tests also passed on this head.cargo test --bin thirdshift ci::tests::dependent_jobs_can_raise_both_pending_and_listed_counts -- --exactfailed on the old wording.After: passes with the exact
2/2 → 1/2 → 3/4 → passedprogress sequence.cargo test --bin thirdshift ci::tests::a_changed_listed_count_is_reported_even_when_pending_is_unchanged -- --exactfailed because the1/2line was missing after1/1.After: passes, including suppression of repeated identical pairs.
cargo test --bin thirdshift ci::tests::: 27 passed, including check-disappearance and Check re-run gating.cargo test --test ci: 23 passed, including pass/fail, Inherited failures and Check re-run Delivery behavior.cargo test: passed (two existing ignored unit tests). After integrating concurrent branch work,git diff fbc8711 HEAD -- src/ci.rs tests/ci.rsis empty: the final source and tests are the exact blobs validated by that run. Typechecking, both CI test groups, and formatting also passed after the merge.cargo check --all-targets,cargo fmt --check, andcargo clippy --all-targets -- -D warnings: passed.Test seams
Outsideseam: scripted GitHub listings, returned CI outcome, and emitted progress lines.Scenarioseam: stderr and Delivery outcome with fake GitHub.Unaddressed findings
b05ada2deef2d147b4414b003ec7c9a42726d9d4...HEADand supporting GitHub, CI, logging, and Delivery code found no introduced security findings. Network-isolated, offline validation passed: 27 CI unit tests (cargo test --offline --locked --bin thirdshift ci::tests:: -- --test-threads=2) and 23 CLI CI integration tests (cargo test --offline --locked --test ci -- --test-threads=2).Security review outcome
No unaddressed introduced findings.
Review coverage
Both reviewers refreshed the final
main...HEADdiff ataed28d2, withmainfixed atb05ada2deef2d147b4414b003ec7c9a42726d9d4, and again reported zero findings.Both independent reviewers read every changed file:
README.md,src/ci.rs, andtests/ci.rs. Changed files left unread: none.Merge Danger
Door: two-way
Blast Radius: CI
Changes progress wording and duplicate suppression; no merge or CI gating rules change.
Built with codex · gpt-6.1-sol · high