Skip to content

Clarify CI progress as checks listed so far - #751

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-289
Oct 17, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-289

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

-CI on abcdef0: 3 of 6 checks still running
+CI on abcdef0: 3 still running out of 6 checks listed so far

 on_poll
-  report when pending changes
+  report when (pending, listed total) changes

Explain why dependent and matrix jobs can increase both counts. Keep identical repeated pairs quiet and retain existing Delivery gates.

Closes #289

Evidence

  • Final shared head aed28d2: cargo nextest run passed all 1,807 tests across 43 binaries (2 existing ignored tests skipped). Formatting, cargo check --all-targets, Clippy, all 27 CI unit tests, and all 23 CI integration tests also passed on this head.
  • Before: cargo test --bin thirdshift ci::tests::dependent_jobs_can_raise_both_pending_and_listed_counts -- --exact failed on the old wording.
    After: passes with the exact 2/2 → 1/2 → 3/4 → passed progress sequence.
  • Before: cargo test --bin thirdshift ci::tests::a_changed_listed_count_is_reported_even_when_pending_is_unchanged -- --exact failed because the 1/2 line was missing after 1/1.
    After: passes, including suppression of repeated identical pairs.
  • cargo test --bin thirdshift ci::tests::: 27 passed, including check-disappearance and Check re-run gating.
  • cargo test --test ci: 23 passed, including pass/fail, Inherited failures and Check re-run Delivery behavior.
  • Full cargo test: passed (two existing ignored unit tests). After integrating concurrent branch work, git diff fbc8711 HEAD -- src/ci.rs tests/ci.rs is empty: the final source and tests are the exact blobs validated by that run. Typechecking, both CI test groups, and formatting also passed after the merge.
  • cargo check --all-targets, cargo fmt --check, and cargo clippy --all-targets -- -D warnings: passed.

Test seams

  • CI watch through its existing Outside seam: scripted GitHub listings, returned CI outcome, and emitted progress lines.
  • CLI CI waits through the existing Scenario seam: stderr and Delivery outcome with fake GitHub.

Unaddressed findings

  • Standards: None.
  • Spec: None.
  • Security: None. Single-session guidance review of b05ada2deef2d147b4414b003ec7c9a42726d9d4...HEAD and supporting GitHub, CI, logging, and Delivery code found no introduced security findings. Network-isolated, offline validation passed: 27 CI unit tests (cargo test --offline --locked --bin thirdshift ci::tests:: -- --test-threads=2) and 23 CLI CI integration tests (cargo test --offline --locked --test ci -- --test-threads=2).

Security review outcome

No unaddressed introduced findings.

Review coverage

Both reviewers refreshed the final main...HEAD diff at aed28d2, with main fixed at b05ada2deef2d147b4414b003ec7c9a42726d9d4, and again reported zero findings.

Both independent reviewers read every changed file: README.md, src/ci.rs, and tests/ci.rs. Changed files left unread: none.

Merge Danger

Door: two-way

Blast Radius: CI

Changes progress wording and duplicate suppression; no merge or CI gating rules change.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 3471763 into main Oct 17, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-289 branch October 17, 2026 09:02
@JacobStephens2
JacobStephens2 restored the issue-289 branch October 17, 2026 09:05
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

understand or clarify stderr CI output of run - why 3 of 6 then 2 of 6 then 3 of 6?

1 participant