Repository navigation
Show the issue URL when closing a merged issue fails - #750
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Include the Issue URL when closing an issue after a confirmed Self-merge fails. Keep the manual close command and the successful merge outcome.
Closes #193
Evidence
cargo test --test merge_run an_issue_close_failure_links_the_issue_and_keeps_the_manual_close_command -- --exactfailed: the warning omitted the URL.After: the same test passes, checking the warning's exact URL, issue number, repository, close command, and explanatory comment. The confirmed merge remains successful and local cleanup completes.
thirdshift merge <Issue URL>through the CLI, using real Git and the existing fake GitHub and Harness executables.cargo check,cargo fmt --check,cargo clippy --all-targets -- -D warnings, and all 28 tests incargo test --test merge_runpass.cargo testsuite passes: 1,805 passed, 0 failed, 2 ignored.Review
Independent Standards and Spec reviews used
main(ecbba89) as the fixed point. Both found no findings and read both changed files:src/delivery.rsandtests/merge_run.rs.Changed files left unread: none on either axis.
Unaddressed findings
ecbba89caf107a5e99e95c498e18a29105c6bf4dcovered both changed files and the supporting Issue URL parsing, Origin match, GitHub close operation, and warning/log output. No introduced Security findings were identified.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the warning text change to roll back.
Blast Radius: warnings
Only the issue-close failure warning after a confirmed Self-merge changes.
Built with codex · gpt-6.1-sol · high