Skip to content

Fix CI-fix Repair ownership of intermittent failures - #693

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-687
Oct 14, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-687

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

CI-fix Repairs must fix intermittent failures in tests or checks the Issue branch added or changed. CI notes require an untouched check and evidence that the failure is unrelated. thirdshift owns re-running and watching CI.

 CI-fix Repair
-  flaky failure → CI notes
+  branch added or changed the failing test/check → fix its root cause
+  untouched test/check + unrelatedness evidence → CI notes
+  never re-run CI jobs or wait on CI; thirdshift owns the Check re-run

Regenerated both CI-fix Repair prompt variants and the Prompts and skills page.

Closes #687

Evidence

  • Before: cargo test --test ci red_ci_is_handed_to_a_ci_fix_repair_whose_fix_turns_it_green -- --exact failed first for the missing branch-ownership/waiver instructions, then for the missing CI re-run/wait prohibition.
    After: the retained prompt expectations pass in cargo test --test ci (23 tests), covering Repairs with and without Inherited failures.
  • UPDATE_PROMPTS=1 cargo test prompts_page: 10 passed; regenerated artifacts match the prompt module.
  • cargo check --all-targets, cargo fmt --check, and cargo clippy --all-targets -- -D warnings: passed.
  • cargo test: full Rust suite passed, including generated-prompt verification without update mode.
  • cd site && npm test: 3 passed on the regenerated page.

Test seams

  • The CI-fix Repair Session prompt delivered to the Harness through a Run (tests/ci.rs).
  • Generated prompt Markdown and the Prompts and skills page (cargo test prompts_page).

Unaddressed findings

  • Standards: none (0 findings).
  • Spec: none (0 findings).
  • Unread changed files: none under either axis; both reviewers read all five changed files against main.

Merge Danger

Door: two-way

A prompt-only policy change with generated documentation and integration expectations; reversible by reverting the commit.

Blast Radius: Repair

Changes the instructions CI-fix Repair sessions receive, including the variant listing Inherited failures.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 9632dec into main Oct 14, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-687 branch October 14, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI-fix Repair waives a flaky test the branch itself added, and re-runs CI on its own

1 participant