Repository navigation
Clarify model execution evidence in run notifications - #664
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify whether a Run notification has evidence of the Model used. The email marks configured settings and reported Models, and explains that a launched Harness does not confirm an unreported Model.
Closes #662
Evidence
cargo test --test run_notification a_codex_notification_distinguishes_launched_sessions_from_unconfirmed_models -- --exactfailed because the email did not distinguish configuration from confirmation. The reported-Model regression also failed before the(reported)annotation was added.After: Both regressions pass, including a review reporting a different Model from the configured one.
cargo test --test run_notification: 30 passed;cargo test session::recording --bin thirdshift: 12 passed;cargo test --test pickup_run: 60 passed;cargo test --test harness_choice: 10 passed.cargo check,cargo fmt --check, andcargo clippy --all-targets -- -D warningspass.cargo testrun passed every target beforesite_deploy, where the unchanged systemd check rejected a warning from an unrelated/etc/systemd/systemservice. The same test passes with the host's custom unit directory excluded. Allsite_deploytests and remaining suite targets pass withSYSTEMD_UNIT_PATH=/usr/lib/systemd/system:/lib/systemd/system cargo test --test site_deploy --test spec_run --test toolchain --test update --test user_config. No deployment files changed.Test seams
notification_linesinterface: attribution survives failures and retained-evidence replacement.Review
thirdshift-code-reviewagainstmain: Standards 0 findings; Spec 0 findings. Each axis read all seven changed files. Changed files left unread: none.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Notification wording and regression expectations; no persisted schema or execution changes.
Blast Radius: notifications
Run notification consumers see the clearer Model annotations and configuration label.
Built with codex · gpt-6.1-sol · high