Repository navigation
Deepen Harness retained completion behind Interpretation - #644
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep retained completion policy inside each Harness adapter. Recording consumes completion progress from the report; Interpretation preserves lifecycle and error precedence.
Muse and OpenCode keep their existing text, usage, Model attribution, failure, and interruption rules. Stream-only Harnesses gain no completion Model lines. The Standards finding about duplicated Model formatting is addressed by a shared report helper, which each retained adapter opts into.
Closes #643
Evidence
cargo test --bin thirdshift harness::interpretation_tests::muse_completion_reports_retained_model_order_and_multiplicityfailed: completion progress was[]instead ofModel: first,Model: second,Model: first. The OpenCode equivalent also failed with missing progress.After: all 22 Interpretation tests pass, including retained order, multiplicity, fallback, and authoritative empty Models/usage.
cargo test --bin thirdshift session::recording::tests::completion_progress_comes_from_interpretation_without_duplicate_live_linesomitted retained progress when Choice named Claude.After: all 12 Recording tests pass, including report-owned progress, empty retained sets, one live Model line, captured Command ownership, and interrupted checkpoints.
cargo test --test muse_sessions --test opencode_sessions: 26 passed.cargo check --all-targets,cargo fmt --check, andcargo clippy --all-targets -- -D warnings: passed. Focused Interpretation/Recording tests and clippy were rerun after the review fix.SYSTEMD_UNIT_PATH="$PWD/site/deploy:/usr/lib/systemd/system" cargo test: 1717 passed, 1 ignored across 41 test binaries on final commitd078bd7.tests/site_deploy.rsand failed because systemd verification loaded/etc/systemd/system/career-dashboard-secrets.service, whoseRequiredBykey is in the wrong section. The unchanged test passes withSYSTEMD_UNIT_PATH="$PWD/site/deploy:/usr/lib/systemd/system"; the final full run uses that unit search path. Repository units and tests are unchanged, and verification still runs.Test seams
condense,observed_models,finish, and captured check validation, with isolated Muse records and a fake OpenCode executable.Recording::runandnotification_lines: progress, retained authority, owning Command evidence, and interrupted checkpoints.Unaddressed findings
Standards
None. S1 (possible duplicated Model formatting) was addressed and verified by the reviewer.
Spec
None. The reviewer identified no findings.
Review coverage: no changed file was left unread by either axis. Both reports include their final files-read lists and fix-verification addenda.
Merge Danger
Door: two-way
Internal refactor; reverting restores the prior implementation without a data migration.
Blast Radius: Harness
Session completion and progress reporting for all Harnesses; retained reconciliation remains specific to Muse and OpenCode.
Built with codex · gpt-6.1-sol · high