Repository navigation
Deepen Harness stream interpretation with semantic evidence - #641
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Concentrate live protocol predicates in the existing dialect decoders for all six Harnesses. Keep
Interpretation's caller interface and existing Session outcomes.Closes #640
Evidence
Interpretationsent each raw line to the decoder and separate Model/Security observers. The added assistant-attribution fixture passed against that implementation (cargo test --bin thirdshift harness::interpretation_tests: 13 passed), establishing behavior to preserve.After: the decoder returns an owned
StreamUpdate; shared Model and Security policy contains no JSON parsing or Harness selection.cargo test --bin thirdshift harness::: 134 passed.cargo check --all-targets,cargo fmt --check, andcargo clippy --all-targets -- -D warnings: passed.SYSTEMD_UNIT_PATH=/usr/lib/systemd/system:/lib/systemd/system cargo test: 1713 passed, 1 existing test ignored, 0 failed across 41 test binaries.cargo testencountered a warning from this machine's unrelated/etc/systemd/system/career-dashboard-secrets.serviceinsite_deploy::the_systemd_units_verify. The test and deployment units are unchanged frommain; the exact test passed when systemd lookup was restricted to vendor units. The complete-suite command above uses that same environment isolation.Test seams
Interpretationinterface:condense,observed_models,for_security, andfinish, exercised through real Harness adapters.Review
Independent Standards and Spec reviews against
mainat86c3efc: 0 findings on each axis. Each reviewer read all nine changed files. Changed files left unread: none.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Reversible internal refactor; no migration or new dependency.
Blast Radius: Sessions
All six Harnesses use this decoder interface for live progress and evidence.
Built with codex · gpt-6.1-sol · high