Skip to content

Describe Architect run work in notification emails - #636

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-631
Oct 10, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-631

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Architect run notifications include the Architecture review issue's title, so the Day shift can see what was proposed without opening a link.

 Result:       merged
 Review:       plan published: <Issue URL>
+Description:  Deepen the session module
 Dispatched:   merged
 Pull request: <PR URL>

The title is captured with the existing issue view and retained through dispatch, including failed Runs and Spec runs. It is omitted when unavailable. README documents the new line.

Closes #631

Evidence

  • Before: cargo test --test architect_run plan_only_sends_one_notification_naming_the_plan -- --exact failed because the received email lacked Description: Deepen the session module.
    After: The same test passes. All 80 Architect run integration tests pass, including plan-only, filed and existing ideas, dispatched Runs, Spec runs, Base fixes and failed dispatches.
  • cargo check --all-targets, cargo fmt --check, cargo clippy --all-targets -- -D warnings, and the notification and Run ending unit tests pass.
  • cargo test passed all tests before site_deploy, then stopped on a host-only systemd warning from /etc/systemd/system/career-dashboard-secrets.service (RequiredBy in [Unit]). The unchanged the_systemd_units_verify test passes with SYSTEMD_UNIT_PATH=/usr/lib/systemd/system:/lib/systemd/system, which excludes local host units. All remaining test binaries passed with that setting: SYSTEMD_UNIT_PATH=/usr/lib/systemd/system:/lib/systemd/system cargo test --test site_deploy --test spec_run --test toolchain --test update --test user_config. Together the runs cover the full suite (939 unit tests passed; one pre-existing ignored test).

Test seam: the thirdshift architect CLI and its Run notification received by the local Resend stand-in, with real Git and fake GitHub/Harness executables.

Review

Reviewed against main (246daf5e4b0a1abff94b67c09f757f3254b917f9) using thirdshift-code-review.

  • Standards: 0 findings. All seven changed files read; no unread changed files.
  • Spec: 0 findings. All seven changed files read; no unread changed files.

Reviewer reports, with final files-read lists, are saved at the requested .thirdshift-review-2PNaLS/standards.md and .thirdshift-review-2PNaLS/spec.md paths in the Run worktree.

Unaddressed findings

Standards

None.

Spec

None.

Merge Danger

Door: two-way

Reverting restores the previous notification body. No stored state changes.

Blast Radius: notifications

Architect run emails gain one optional description line; the title comes from the existing review-result query.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 86c3efc into main Oct 10, 2026
17 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-631 branch October 10, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

show description of architect run in notice email

1 participant