Repository navigation
Describe Architect run work in notification emails - #636
Merged
Merged
Conversation
This was referenced Oct 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architect run notifications include the Architecture review issue's title, so the Day shift can see what was proposed without opening a link.
Result: merged Review: plan published: <Issue URL> +Description: Deepen the session module Dispatched: merged Pull request: <PR URL>The title is captured with the existing issue view and retained through dispatch, including failed Runs and Spec runs. It is omitted when unavailable. README documents the new line.
Closes #631
Evidence
cargo test --test architect_run plan_only_sends_one_notification_naming_the_plan -- --exactfailed because the received email lackedDescription: Deepen the session module.After: The same test passes. All 80 Architect run integration tests pass, including plan-only, filed and existing ideas, dispatched Runs, Spec runs, Base fixes and failed dispatches.
cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings, and the notification and Run ending unit tests pass.cargo testpassed all tests beforesite_deploy, then stopped on a host-only systemd warning from/etc/systemd/system/career-dashboard-secrets.service(RequiredByin[Unit]). The unchangedthe_systemd_units_verifytest passes withSYSTEMD_UNIT_PATH=/usr/lib/systemd/system:/lib/systemd/system, which excludes local host units. All remaining test binaries passed with that setting:SYSTEMD_UNIT_PATH=/usr/lib/systemd/system:/lib/systemd/system cargo test --test site_deploy --test spec_run --test toolchain --test update --test user_config. Together the runs cover the full suite (939 unit tests passed; one pre-existing ignored test).Test seam: the
thirdshift architectCLI and its Run notification received by the local Resend stand-in, with real Git and fake GitHub/Harness executables.Review
Reviewed against
main(246daf5e4b0a1abff94b67c09f757f3254b917f9) usingthirdshift-code-review.Reviewer reports, with final files-read lists, are saved at the requested
.thirdshift-review-2PNaLS/standards.mdand.thirdshift-review-2PNaLS/spec.mdpaths in the Run worktree.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Reverting restores the previous notification body. No stored state changes.
Blast Radius: notifications
Architect run emails gain one optional description line; the title comes from the existing review-result query.
Built with codex · gpt-6.1-sol · high