Skip to content

Request fresh Codex reviewers across sessions and Resumes - #619

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-616
Oct 10, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-616

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Codex sessions that run the code review ask for fresh sub-agents, each given only its task and necessary evidence. The launch policy survives Resume.

implement (fresh / Continuation), Spec review, Foreign-commit review Repair
  shared code-review contract → retained CodeReview purpose
    Codex → append fresh-agent request: fork_turns: "none"
    Resume → apply the same request again

The request lives in the Codex Harness. The thread cap remains a Security setting; shared prompts and other Harness protocols are unchanged.

Closes #616

Evidence

  • Before: cargo +stable test --test codex_sessions implement_sessions_and_their_resumes_request_fresh_reviewers -- --exact failed because the implement prompt lacked the fresh-agent request.
    After: that test passes for fresh implement sessions, both Continuation variants, and every Resume. cargo +stable test --test codex_sessions passes all 16 tests, including Spec-review and Foreign-commit Repair Resumes and exclusions for Architecture and CI-fix sessions.
  • cargo +stable clippy --all-targets -- -D warnings passed.
  • cargo +stable fmt --check passed.
  • UPDATE_PROMPTS=1 cargo +stable test prompts_page passed all 10 tests; git diff --exit-code -- prompts confirmed no generated changes.
  • All 41 test binaries covered: 1665 passed, 1 pre-existing ignored test. The full invocation and environment recovery are documented below.

Validation uses installed stable Rust 1.95.0: this environment's pinned 1.99.0 toolchain has no rustc binary.

Test seams

  • The thirdshift command launching the Harness CLI: recorded Codex prompts and argv for implement, Continuation, Spec review, Foreign-commit Repair and Resumes; unchanged Architecture and CI-fix sessions.
  • Generated prompts page: regeneration leaves tracked prompts unchanged.

Unaddressed findings

  • Standards: none. The fresh reviewer reported zero findings and read all four changed files.
  • Spec: none. The fresh reviewer reported zero findings and read all four changed files.
  • Changed files left unread: none on either axis.

CI notes

The full cargo +stable test invocation stopped at site_deploy::the_systemd_units_verify because an unrelated host unit under /etc/systemd/system/ emitted an unknown RequiredBy directive warning. The test and deployment units match main (git diff main -- tests/site_deploy.rs site/deploy is empty).

The exact test then passed with SYSTEMD_UNIT_PATH=/usr/lib/systemd/system, which retains verification of the repository's explicit unit files using systemd's documented unit search path. Site-deploy and all binaries Cargo had not reached then passed with:

SYSTEMD_UNIT_PATH=/usr/lib/systemd/system cargo +stable test --test site_deploy --test spec_run --test toolchain --test update --test user_config

Every test binary has a passing final run; the only ignored test was already ignored on main.

Merge Danger

Door: two-way

Reverting restores the previous launch prompts; no data migration.

Blast Radius: sessions

Codex reviewer instructions change for code-review sessions and their Resumes.

Built with codex · gpt-6.1-sol · high

Preserve both Adapter methods: code-review sessions retain independent Codex reviewers across Resumes, and release summaries retain main's restricted invocation and input transport.

Validated with Rust 1.99: cargo check, clippy with warnings denied, formatting, shell syntax, and all 41 test binaries (1679 passed, 1 existing ignored). Deployment verification passed with SYSTEMD_UNIT_PATH=/usr/lib/systemd/system to exclude an unrelated invalid host unit. Prompt regeneration left generated files unchanged.
@JacobStephens2
JacobStephens2 merged commit fb391f9 into main Oct 10, 2026
17 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-616 branch October 10, 2026 08:16
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codex sessions that run the code review ask for fresh sub-agents

1 participant