Repository navigation
Request fresh Codex reviewers across sessions and Resumes - #619
Merged
Merged
Conversation
Preserve both Adapter methods: code-review sessions retain independent Codex reviewers across Resumes, and release summaries retain main's restricted invocation and input transport. Validated with Rust 1.99: cargo check, clippy with warnings denied, formatting, shell syntax, and all 41 test binaries (1679 passed, 1 existing ignored). Deployment verification passed with SYSTEMD_UNIT_PATH=/usr/lib/systemd/system to exclude an unrelated invalid host unit. Prompt regeneration left generated files unchanged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex sessions that run the code review ask for fresh sub-agents, each given only its task and necessary evidence. The launch policy survives Resume.
The request lives in the Codex Harness. The thread cap remains a Security setting; shared prompts and other Harness protocols are unchanged.
Closes #616
Evidence
cargo +stable test --test codex_sessions implement_sessions_and_their_resumes_request_fresh_reviewers -- --exactfailed because the implement prompt lacked the fresh-agent request.After: that test passes for fresh implement sessions, both Continuation variants, and every Resume.
cargo +stable test --test codex_sessionspasses all 16 tests, including Spec-review and Foreign-commit Repair Resumes and exclusions for Architecture and CI-fix sessions.cargo +stable clippy --all-targets -- -D warningspassed.cargo +stable fmt --checkpassed.UPDATE_PROMPTS=1 cargo +stable test prompts_pagepassed all 10 tests;git diff --exit-code -- promptsconfirmed no generated changes.Validation uses installed stable Rust 1.95.0: this environment's pinned 1.99.0 toolchain has no
rustcbinary.Test seams
Unaddressed findings
CI notes
The full
cargo +stable testinvocation stopped atsite_deploy::the_systemd_units_verifybecause an unrelated host unit under/etc/systemd/system/emitted an unknownRequiredBydirective warning. The test and deployment units matchmain(git diff main -- tests/site_deploy.rs site/deployis empty).The exact test then passed with
SYSTEMD_UNIT_PATH=/usr/lib/systemd/system, which retains verification of the repository's explicit unit files using systemd's documented unit search path. Site-deploy and all binaries Cargo had not reached then passed with:SYSTEMD_UNIT_PATH=/usr/lib/systemd/system cargo +stable test --test site_deploy --test spec_run --test toolchain --test update --test user_configEvery test binary has a passing final run; the only ignored test was already ignored on main.
Merge Danger
Door: two-way
Reverting restores the previous launch prompts; no data migration.
Blast Radius: sessions
Codex reviewer instructions change for code-review sessions and their Resumes.
Built with codex · gpt-6.1-sol · high