[JacobStephens2]

Summary

Security run ends
  skipped → no notification
  email requested → one Resend request
    audit outcome
    each finding: severity (if known), title, private record link
    local log paths

Keep recorded finding metadata through partial recording failures. Detailed Security audit failure causes remain in local logs because verifier commands and Harness diagnostics can contain private write-up.

Closes #539

Evidence

• Before: a_completed_security_audit_sends_one_notification_when_asked failed with zero Resend requests.
  After: one request with the Security run outcome and recipient.
• Before: each reviewer's exact regression failed because the Resend Cause included private trace or finding description.
  After: both exact commands passed, and both tests remain in tests/security_run.rs:

  cargo test --test security_run security_notification_omits_private_background_trace -- --exact
  cargo test --test security_run failed_security_notification_excludes_description_from_killed_verifier -- --exact --nocapture

• Validation: cargo check, cargo fmt --check, cargo clippy --all-targets -- -D warnings, and the full CARGO_BUILD_JOBS=2 cargo test passed (1532 tests passed, 1 ignored, zero failures). The Security run suite passed all 24 tests.

Testing seams

• The existing end-to-end scenario harness: real binary and git, fake GitHub and Harness CLIs, local Resend stand-in. Covers email/config defaults and overrides, safe finding metadata, partial recording failure, failed and interrupted audits, Ready issue and lock skips, preflight checks, and send failure outcomes.

Unaddressed findings

Standards

None. The one ADR 0015 privacy finding was reproduced and fixed.

Spec

None. The one #539 confidentiality finding was reproduced and fixed.

Both reviewers read all 10 changed files. Changed files left unread: none under Standards or Spec. Review fixed point: issue-427 at 8b775669cb8bbc1bbd815428337ac587477d2151 (remote branch pinned after fetch; the local branch was stale).

Merge Danger

Door: two-way

Reverting restores the previous Security notification behavior; no migration or stored-record change.

Blast Radius: notifications

Security runs now honor the existing email defaults and checks. A delivery error remains a warning; skipped runs send none.

Built with codex · gpt-6.1-sol · xhigh