Skip to content

Trial the Security review's two modes - #557

Merged
JacobStephens2 merged 2 commits into
issue-427from
issue-549
Oct 8, 2026
Merged

JacobStephens2 merged 2 commits into
issue-427from
issue-549

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

Measured the Security review’s two candidate modes on three recent merged PRs, for the Day shift’s choice.

3 merged PRs × 2 modes × 2 Harnesses = 12 report-only sessions
├── measurements → docs/research/security-review-mode-trial.md
└── finding details → private grading file, mode 600

Claude Code ran claude-opus-5-5 at medium; Codex ran gpt-6.1-sol at xhigh. Each session used its own clone without remotes, with at most two trial sessions active and a 45-minute timeout. The note documents cached-token accounting and the limits of this Rust-only, source-only sample. The Day shift’s grades and mode choice remain open.

Closes #549

Evidence

  • Before: no diff-mode comparison covering these twelve cells existed at the Base branch.
    After: all twelve sessions completed; all six full audits passed both native validators. The delivery check verified every clone clean and remote-free, every private finding retained with a blank grade, mode 600, and no finding titles/details in the note or this body.
  • Passed cargo check --all-targets, cargo fmt --check, cargo clippy --all-targets -- -D warnings, and all five packaging tests.
  • Passed all 65 Node validator tests and the full cargo test suite: 1,503 passed, one ignored, zero failed.

Merge Danger

Door: two-way

A research note; reverting it changes no factory behavior. Finding details stay on this machine.

Blast Radius: research

Unaddressed findings

Standards

None. Zero findings.

Spec

None. Zero findings.

Review coverage

Fixed point: issue-427, pinned to its upstream commit 2ddf4b78da3bc00b47ba02ec4584180090f0ee7f.

Both Standards and Spec read the only changed file, docs/research/security-review-mode-trial.md. Changed files left unread: none. Each reviewer’s final report and files-read list are saved locally in .thirdshift-review-gojJXZ/standards.md and .thirdshift-review-gojJXZ/spec.md.

Built with codex · gpt-6.1-sol · xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant