Skip to content

Prefactor shared Pass lock, logging and command words - #555

Merged
JacobStephens2 merged 3 commits into
issue-427from
issue-536
Oct 8, 2026
Merged

JacobStephens2 merged 3 commits into
issue-427from
issue-536

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

- an Architect run or a Pickup run is already running on <owner>/<repo>
+ another Pass is already running on <owner>/<repo>

Share Pass command words and per-kind Activity log formatting so a new kind uses the same logic. Generalize help and module docs. The lock keeps its existing path and process lifetime.

Closes #536

Evidence

  • Before: cargo test --test activity_log a_skip_because_another_pass_is_running_is_recorded_like_any_other -- --exact failed because the log used the old two-kind reason.
    After: the same test passes with the new reason for both Architect and Pickup skips.

  • Before: the strengthened base-help assertion failed because help still said “for architect and pickup only”.
    After: all 29 command-surface tests pass, including the retained base-help and Pickup lock-description regressions.

  • Final validation: cargo check --all-targets, cargo fmt --check, cargo clippy --all-targets -- -D warnings, and cargo test passed. The full suite passed 1,501 tests with 0 failures and 1 existing ignored test.

Merge Danger

Door: two-way

Blast Radius: Passes

Scheduled Passes share the same lock file as older versions. Skip output changes wording; skip history stays separate by kind.

Test seams

  • Command entry point: Architect and Pickup runs contending for the per-repository Pass lock, including stderr and Activity log output; help describes the shared Pass words.
  • Owned logging interface: per-kind skip history across recordings, with intervening starts and ends.
  • Argument parser interface: shared dispatch words, repeats, contradictions, and Base branch selection on each Pass.

Review

  • Standards: 0 findings.
  • Spec: 2 findings, both reproduced and fixed; the regression tests are kept.
  • Changed files left unread: none under Standards or Spec; both reviewers read all 19 changed files.

Unaddressed findings

Standards

None.

Spec

None.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit cc7e3be into issue-427 Oct 8, 2026
13 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-536 branch October 8, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant