Repository navigation
Prefactor shared Pass lock, logging and command words - #555
Merged
Merged
Conversation
This was referenced Oct 8, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share Pass command words and per-kind Activity log formatting so a new kind uses the same logic. Generalize help and module docs. The lock keeps its existing path and process lifetime.
Closes #536
Evidence
Before:
cargo test --test activity_log a_skip_because_another_pass_is_running_is_recorded_like_any_other -- --exactfailed because the log used the old two-kind reason.After: the same test passes with the new reason for both Architect and Pickup skips.
Before: the strengthened base-help assertion failed because help still said “for architect and pickup only”.
After: all 29 command-surface tests pass, including the retained base-help and Pickup lock-description regressions.
Final validation:
cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings, andcargo testpassed. The full suite passed 1,501 tests with 0 failures and 1 existing ignored test.Merge Danger
Door: two-way
Blast Radius: Passes
Scheduled Passes share the same lock file as older versions. Skip output changes wording; skip history stays separate by kind.
Test seams
Review
Unaddressed findings
Standards
None.
Spec
None.
Built with codex · gpt-6.1-sol · xhigh