Repository navigation
Reconcile head CI when a Check re-run is refused - #514
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A CI-fix Repair can re-run checks without changing the head. A refused Check re-run now refreshes CI instead of failing the Run from the cached failures.
ADR-0010, the domain wording, and README describe the revised refusal behavior.
Evidence
After:
a_repair_that_already_re_ran_ci_to_green_delivers_or_self_merges_the_unchanged_headpasses for Delivery and Self-merge, with both green and pending-to-green checks. Self-merge uses exactly the verified, unchanged head.cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings;cargo test -- --test-threads=1all pass (1435 tests passed, 1 existing ignored test).cargo teststopped separately onan_interrupted_catalog_read_is_an_error_instead_of_retentionandan_interrupted_model_check_is_an_error_instead_of_retrying_the_pair; a four-thread run stopped onrepository_lock_is_shared_by_worktrees_and_owned_until_drop. These unchanged tests each passed when rerun in isolation.Scenario(Delivery and Self-merge); CI watch and Check re-run throughOutsidewithInMemory(GitHub and polling boundary).main(d000eee8a0912f165c2707ebfbfb2027777822e6). Standards and Spec reviewed independently in parallel.Merge Danger
Door: two-way
Code and documentation changes; no migration or increase to Repair/re-run budgets.
Blast Radius: CI
The unchanged-head Check re-run can continue Delivery or Self-merge from freshly verified CI. Once checks have appeared, a listing that disappears during a watch now fails verification.
Unaddressed findings
Standards
None. The Standards review reported no findings.
Spec
None. The Spec review reported no findings.
Closes #508
Built with codex · gpt-6.1-sol · xhigh