Repository navigation
Keep reviewer reports beside Session logs - #512
Merged
Merged
Conversation
This was referenced Oct 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sessions names a report directory that git ignores in every review prompt and keeps each available report beside its Session log, including Resume logs. The Factory skill writes both axes with their final files-read lists when the prompt names a destination.
Closes #490
Evidence
keeps_review_reports_beside_each_harness_session_logfailed because the prompt named no report directory.After: It passes for all six Harnesses. Sessions execution tests also cover missing reports carrying on, Resume reports, and a failed session preserving its available report.
Sessions::withinthrough the execution-test seam with fake Harness CLIs; the existing prompts-page generation seam.UPDATE_PROMPTS=1 cargo test prompts_page.cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings, Sessions execution tests, fresh Run and Merge run tests, and the fullcargo test -- --test-threads=4suite.issue-486at501cb049fd23bb4de62c561284463d6883072c03: Standards found one comment vocabulary mismatch, which was fixed; Spec found none. Both reviewers read all 16 changed files. Unread changed files: none on either axis.Merge Danger
Door: two-way
Revert the change to remove report retention; no migration is required.
Blast Radius: Sessions
Review sessions on every Harness gain report paths and report copies. Missing reports produce a progress line; their contents do not affect Run decisions.
Unaddressed findings
Standards
None. The finding about using “Session log” in the test comment was addressed.
Spec
None.
Built with codex · gpt-6.1-sol · xhigh