Skip to content

Keep reviewer reports beside Session logs - #512

Merged
JacobStephens2 merged 2 commits into
issue-486from
issue-490
Oct 7, 2026
Merged

JacobStephens2 merged 2 commits into
issue-486from
issue-490

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Sessions names a report directory that git ignores in every review prompt and keeps each available report beside its Session log, including Resume logs. The Factory skill writes both axes with their final files-read lists when the prompt names a destination.

 sessions/7-<stamp>-implement.jsonl
+sessions/7-<stamp>-implement.standards
+sessions/7-<stamp>-implement.spec

Closes #490

Evidence

  • Before: keeps_review_reports_beside_each_harness_session_log failed because the prompt named no report directory.
    After: It passes for all six Harnesses. Sessions execution tests also cover missing reports carrying on, Resume reports, and a failed session preserving its available report.
  • Seams: Sessions::within through the execution-test seam with fake Harness CLIs; the existing prompts-page generation seam.
  • Regenerated the prompts page and prompt files with UPDATE_PROMPTS=1 cargo test prompts_page.
  • Validation, all passed: cargo check --all-targets, cargo fmt --check, cargo clippy --all-targets -- -D warnings, Sessions execution tests, fresh Run and Merge run tests, and the full cargo test -- --test-threads=4 suite.
  • The default-parallel full run hit an existing child-process cleanup test's four-second timing assertion. That test passed in isolation in 2.00s; the full-suite retry with four test threads passed.
  • Review against issue-486 at 501cb049fd23bb4de62c561284463d6883072c03: Standards found one comment vocabulary mismatch, which was fixed; Spec found none. Both reviewers read all 16 changed files. Unread changed files: none on either axis.

Merge Danger

Door: two-way

Revert the change to remove report retention; no migration is required.

Blast Radius: Sessions

Review sessions on every Harness gain report paths and report copies. Missing reports produce a progress line; their contents do not affect Run decisions.

Unaddressed findings

Standards

None. The finding about using “Session log” in the test comment was addressed.

Spec

None.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit f7a2a2f into issue-486 Oct 7, 2026
13 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-490 branch October 7, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant