Skip to content

Use one origin sample for Launch directory Base branches - #500

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-499
Oct 7, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-499

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Base branch validation and optional Launch directory pulling now share one immutable origin sample.

prepare_base_branch → BaseBranch
  sample qualified origin and local commits
  reject unpushed local work
BaseBranch.name()
BaseBranch.pull()
  recheck the checked-out branch
  fast-forward toward the sampled origin commit

Run and Spec run preparation includes the requested pull before Claim. Architect retains the value until after its gates, Harness check and start record. Pickup updates through its dispatched Run; Worktree acquisition samples independently.

Closes #499

Evidence

  • Before: Real Git regression probes failed: a main tag hid unpushed work, a rewound tracking ref changed the pull target, and a deferred pull updated a switched checkout.
    After: All 18 Launch directory tests pass, covering shadow refs, tracking-ref advance/rewind/replacement/deletion, unchanged branches/index/files, fast-forward-only updates and recorded interruption.
  • Existing startup command tests: 156 passed across preflight, launch pulling, Architect and Pickup. Run/Spec execution tests preserve preparation and pull before Claim, including Continuation's open PR Base branch precedence.
  • Required checks pass: cargo fmt --check, cargo clippy --all-targets -- -D warnings, and cargo test. cargo check --all-targets also passes.

Test seams

  • Launch directory preparation and the prepared Base branch's name/pull interface, using real Git and an isolated bare origin.
  • Existing Run and Pass execution seams for startup, selection, Claim timing, and Architect/Pickup gates.
  • Existing command interface for preflight, Continuation precedence, and warning-only checkout updates.

Unaddressed findings

Standards

None; the review against main reported no findings.

Spec

None; the review against main reported no findings.

Merge Danger

Door: two-way

Reversible code and glossary changes; checkout updates remain fast-forward only and preserve local work on failure.

Blast Radius: startup

Base branch preflight and optional Launch directory updates for Runs, Spec runs and passes.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 33dbaa1 into main Oct 7, 2026
13 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-499 branch October 7, 2026 07:27
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deepen Launch directory Base branch preparation around one origin sample

1 participant