Repository navigation
Require evidence for correctness findings and declines - #497
Merged
Merged
Conversation
This was referenced Oct 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require runnable evidence for correctness findings on both review axes, and evidence for every decline. The shared instruction reaches Fresh, Continuation, Spec review and the Repair that reviews Foreign commits; the generated prompts page and glossary match.
New decision issues carry only
needs-triageand describe the finding, evidence, originating pull request and why the call is outside the agent's authority. Both reviewer briefs include one shared evidence rule, with 800 words of prose and full tests/commands outside the limit.Closes #488
Evidence
cargo test prompts_pagefailed both stale-output checks (6 passed, 2 failed).cargo test --test fresh_runfailedgives_the_agent_the_fresh_promptagainst the old literal prompt (18 passed, 1 failed).After: regenerated outputs pass all 8
prompts_pagetests; the updated fresh prompt expectation passes all 19fresh_runtests.cargo check,cargo fmt --check,cargo clippy --all-targets -- -D warnings, and fullcargo testpassed (1344 tests, 0 failures).issue-486ate68dcee: one Standards duplication finding fixed and verified; no Spec findings. Both axes verified the follow-up changes.Seams: the existing prompts-page golden files and the existing Fresh Run end-to-end test that observes the Session prompt sent to the Harness. The skill text was reviewed manually, as #486 specifies.
Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Reverting restores the previous review instructions; no data migration.
Blast Radius: review
Factory reviewer briefs and the four Session prompt types that run code review, including the two Continuation variants.
Built with codex · gpt-6.1-sol · xhigh