Repository navigation
Share review instruction across Session prompts - #494
Merged
Merged
Conversation
This was referenced Oct 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The implement session, fresh and Continuation, the Spec review and the Foreign commits Repair take their review wording from one instruction in the prompt module. Every Session prompt stays byte-for-byte unchanged.
The Spec review keeps
thirdshift-tddand committing. The Repair keeps appending entries marked as coming from Foreign commits and preserving the rest of the PR body.Evidence
cargo test prompts_pagepasses all 8 golden/rendering tests.After: One shared instruction supplies that wording;
cargo test --bin thirdshift prompts_pagepasses the same 8 tests.UPDATE_PROMPTS=1 cargo test prompts_pagesucceeds, andgit diff --exit-code issue-486 -- site/prompts/index.html promptsconfirms regeneration changes nothing.cargo fmt --check,cargo check --all-targetsandcargo clippy --all-targets -- -D warningspass.cargo test: 1344 passed, 0 failed, 1 existing ignored local latency probe.prompts_page_shows_what_the_binary_sendsandprompt_files_show_what_the_binary_sends); factory execution through the existing CLI integration suite.thirdshift-code-reviewreviews againstissue-486: Standards 0 findings; Spec 0 findings. Both reviewers read the full changed file.Merge Danger
Door: two-way
Blast Radius: prompts
Internal refactor with unchanged instructions and generated files.
Unaddressed findings
Standards
None. The Standards review reported no findings.
Spec
None. The Spec review reported no findings.
Closes #487
Built with codex · gpt-6.1-sol · xhigh