Skip to content

Pin Issue branch synchronization to sampled origin commits - #493

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-492
Oct 7, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-492

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Keep synchronization facts inside Worktree and carry sampled commits through Delivery.

sample refs/remotes/origin/<branch> → upstream label + commit ID
Base branch merge → selected commit → CI watch / Check re-run
Foreign observation → spend budget → consume pinned batch
                    → conflict Repair + validation → review from observed local head

Closes #492

Evidence

  • Before: Real-Git regressions failed when the Base tracking ref rewound after merging, the Issue tracking ref advanced after observation, and a local origin/main branch hid Base branch movement. A worktree recreated at the same path also accepted an earlier observation.
    After: All 16 Worktree synchronization tests and 28 Repair-loop tests pass. All 105 existing merge, CI and Spec integration tests pass. cargo fmt --check, cargo clippy --all-targets -- -D warnings, and the complete suite (cargo test -- --test-threads=1) pass, with one existing ignored test.

Two default-parallel full-suite attempts hit OS ETXTBSY (Text file busy) while starting unchanged child-run temporary executable fixtures. All 20 child-run execution tests passed in isolation; final full-suite validation uses cargo test -- --test-threads=1.

Test seams

  • Worktree's public synchronization interface, exercised with real local Git and a bare origin: sampled merge facts, Foreign commit observation and consumption, Base branch movement, Spec catch-up, and conflict completion.
  • Repair loop's existing Delivery boundary: the Base branch commit passed to CI watch and Check re-run, the Foreign commit review fixed point, and budget refusal before mutation.

Unaddressed findings

Standards

None. The Data Clumps finding was addressed by carrying OriginCommit intact through merging; the follow-up review found no new concerns.

Spec

None. The review found no missing requirements, incorrect behavior, or scope creep.

Merge Danger

Door: two-way

Blast Radius: Delivery

Issue branch synchronization, CI comparison, Foreign commit review and Spec catch-up.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit f39281f into main Oct 7, 2026
13 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-492 branch October 7, 2026 05:38
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deepen Worktree ownership of Issue branch synchronization

1 participant