Skip to content

Own complete Command recording in logs - #481

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-477
Oct 7, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-477

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Own each Command's complete record in one logs implementation while preserving the Day shift's existing output, quiet skips, child Run relay and diagnostics.

Command events + stdout/stderr
  → synchronized logs instance
    → owned Record: stamp, held output, Command log, Activity log, warnings
    → private clock/terminal/file seam: OnMachine or Scripted

Closes #477

Evidence

  • Before: the new complete-record interface test failed to compile: could not find effects in logs; lifecycle coverage required binary invocations and private-helper tests.
    After: all 17 recording-interface tests and 21 retained logging CLI tests pass. Four redundant binary permutations and the superseded private-helper tests are replaced by recording-interface coverage.
  • cargo fmt --check, cargo clippy --all-targets -- -D warnings, and the full cargo test suite pass (1301 passed, 1 ignored). cargo check --all-targets also passes.
  • The first full-suite attempt stopped on an_interrupted_model_check_is_an_error_instead_of_retrying_the_pair (Setup ended before its last answer instead of interrupted). Repeated isolated runs reproduced the same failure on main and this branch; it is a pre-existing intermittent Harness test failure.

Test seams

  • The owned logs recording interface: begin, configured, started, skipped, ended, show-held, stdout/stderr output, root, stamp and Command log path, with memory clock/terminal/files.
  • CLI integration: event wiring, local timestamps, Session logs, child Run relay/suppression, notification links, Origin match, non-work commands, quiet skips, concurrent passes and real filesystem failures.

Merge Danger

Door: two-way

Internal ownership refactor; no migration, User config setting or domain behavior change.

Blast Radius: Logging

Command recording and reader-thread output share one lock. Creation, append, Activity and terminal failure combinations and threaded output ordering are covered.

Unaddressed findings

Standards

None — the thirdshift-code-review Standards review against main found no findings.

Spec

None — the thirdshift-code-review Spec review against main found no findings.

CI notes

  • Linux test failed in distinct_children_deliver_out_of_order_with_their_own_endings_and_accounts with Text file busy (os error 26): a pre-existing parallel executable-fixture launch flake, reproduced through the same unchanged fixture on base main (e3c24b2); no branch code or checks changed.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit ca366e0 into main Oct 7, 2026
13 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-477 branch October 7, 2026 03:35
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deepen Command recording into one owned logs implementation

1 participant