Repository navigation
Own complete Command recording in logs - #481
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Own each Command's complete record in one logs implementation while preserving the Day shift's existing output, quiet skips, child Run relay and diagnostics.
Closes #477
Evidence
could not find effects in logs; lifecycle coverage required binary invocations and private-helper tests.After: all 17 recording-interface tests and 21 retained logging CLI tests pass. Four redundant binary permutations and the superseded private-helper tests are replaced by recording-interface coverage.
cargo fmt --check,cargo clippy --all-targets -- -D warnings, and the fullcargo testsuite pass (1301 passed, 1 ignored).cargo check --all-targetsalso passes.an_interrupted_model_check_is_an_error_instead_of_retrying_the_pair(Setup ended before its last answerinstead ofinterrupted). Repeated isolated runs reproduced the same failure onmainand this branch; it is a pre-existing intermittent Harness test failure.Test seams
Merge Danger
Door: two-way
Internal ownership refactor; no migration, User config setting or domain behavior change.
Blast Radius: Logging
Command recording and reader-thread output share one lock. Creation, append, Activity and terminal failure combinations and threaded output ordering are covered.
Unaddressed findings
Standards
None — the
thirdshift-code-reviewStandards review againstmainfound no findings.Spec
None — the
thirdshift-code-reviewSpec review againstmainfound no findings.CI notes
testfailed indistinct_children_deliver_out_of_order_with_their_own_endings_and_accountswithText file busy (os error 26): a pre-existing parallel executable-fixture launch flake, reproduced through the same unchanged fixture on basemain(e3c24b2); no branch code or checks changed.Built with codex · gpt-6.1-sol · xhigh