Repository navigation
Let release.sh start over after a closed bump PR's branch is deleted - #479
Merged
Merged
Conversation
The refusal for a bump PR closed without merging says to "delete release-<version> to start over", but the next run still found the closed PR and refused again. A closed PR whose branch is gone from origin now counts as no earlier run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ts55nZd9iVAg8GP3QxHo9Y
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
release.shfinds a bump PR closed without merging, it refuses with "reopen it or delete release- to start over". Deleting the branch didn't help: the next run still found the closed PR as the newest fromrelease-<version>and refused again, so the version couldn't be released without reopening a stale PR.find_earlier_runnow treats a closed PR whose branch is gone from origin as no earlier run, so the script cuts a fresh bump from current main. A closed PR whose branch is still on origin is still refused.Hit while switching tonight's release from 0.10.1 back to 0.10.0 (#455 closed,
release-0.10.0deleted).Evidence
a_bump_pr_closed_without_merging_and_its_branch_deleted_starts_overfails against the old script with the refusal and passes with the fix.cargo test --test release: 46 passed, 0 failed.shellcheck scripts/release.shclean,cargo fmt --checkclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ts55nZd9iVAg8GP3QxHo9Y