Repository navigation
Make GitHub execution interruptible and preserve finishing workflows - #472
Merged
Merged
Conversation
This was referenced Oct 7, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ordinary GitHub work now stops on Command interruption. Finishing paths keep permission through their prerequisite reads and writes.
Closes #468
Evidence
parent_only_interruption_stops_active_githubwaited for the executable to expire and returned a JSON error after a parent-only signal.After: passes for SIGINT, SIGTERM and SIGHUP; ordinary calls refuse to spawn, completion views remain independent, and cancelled merges require MERGED at the requested head.
an_existing_spec_pr_accounts_for_every_drained_ticket_after_interruptionpersisted both ended Tickets asrunning.After: persists both as
interrupted, with their dependent Ticket blocked and no new Ticket or Spec review started.the_first_landing_opens_its_spec_pr_when_accounting_is_interruptedfailed withno Spec PR.After: completion opens the draft Spec PR and publishes the landed Ticket's checklist despite interruption during title accounting.
cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings, and the fullcargo testsuite passed (1285 passed, 1 ignored). The initial suite attempt stopped on the existing Harness catalog interruption test; its isolated retry and the complete rerun passed.b3c9a41): Standards: 0 findings. Spec: 1 finding, addressed and verified by the Spec reviewer.Testing seams
Merge Danger
Door: two-way
Reversible interface refactor; existing finishing operations retain their retry and warning behavior.
Blast Radius: Commands
Every GitHub CLI operation now shares execution ownership and interruption policy; finishing permission stays confined to the existing completion paths.
Unaddressed findings
Standards
None; the review reported no findings.
Spec
None; the Spec PR creation finding was fixed by using the bound completion view and covered by a failing-then-passing regression.
Built with codex · gpt-6.1-sol · xhigh