Repository navigation
Make Git execution interruptible with completion views - #471
Merged
Merged
Conversation
This was referenced Oct 7, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ordinary Git now stops when its Command is interrupted. Independent completion views finish salvage and cleanup without clearing the interruption or permitting ordinary work to resume.
Optional and boolean Git probes propagate cancellation and transport failures. Git retains its diagnostics and ten-second held-lock retry; GitHub captures remain on their existing implementation for the next Ticket.
Closes #467
Evidence
ordinary_git_refuses_to_spawn_after_interruptionfailed: Git returnedOk("")and ran the alias after SIGINT.After: it returns
interruptedwithout spawning. Git fixtures cover SIGINT, SIGTERM and SIGHUP, active cancellation, independent completion views, optional/boolean answers, transport failures and held-lock retries.sigint_while_the_session_runs_stops_it_and_fails_the_run.After: interrupted salvage pushes the work and removes the worktree; rejected interrupted salvage retains the local work and reports its head. All 12 Failed run and 18 Merge run checks pass.
cargo fmt --checkandcargo clippy --all-targets -- -D warningspass.cargo test: 1,270 passed, 0 failed; the existing manual latency probe remains ignored.Test seams
run,succeeds, optional probes and completion views) against real temporary repositories and executable fixtures, with isolated Command interruption.Review
Reviewed against
issue-465, pinned to1fbb06b, including the inherited #466 prerequisite.Standards
Both findings addressed: removed redundant Git parameters from the Worktree interface and reused the execution owner's signal-test isolation helper. The reviewer verified both fixes.
Spec
No findings.
Unaddressed findings
Standards
None; both findings were addressed.
Spec
None; no findings were reported.
Merge Danger
Door: two-way
No persisted-state migration; reverting restores the prior execution behavior.
Blast Radius: Command
Affects ordinary Git execution and finishing Git operations across Runs, Claims and worktree cleanup.
Built with codex · gpt-6.1-sol · xhigh