Repository navigation
Share Command execution ownership for capture and streaming - #469
Merged
Merged
Conversation
This was referenced Oct 7, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One Command execution owner now supervises captured output and streaming. The Harness adapter still prepares its environment and chooses its stop action and signals.
Ordinary execution observes interruption throughout its lifetime; completion execution finishes independently and leaves the recorded flag intact. Worker completion and unwind wake supervision. Git and GitHub production call sites retain their current behavior for the following Tickets.
Closes #466
Evidence
completion_ignores_recorded_signals_without_permitting_ordinary_workfailed withinterruptedduring completion execution.After: passes for SIGINT, SIGTERM and SIGHUP; completion returns raw bytes/status and ordinary execution still refuses to spawn.
startup_failure_returns_no_state_even_when_the_consumer_has_returnedreturned recovered state after the injected startup fault.After: returns an error without retained state after stopping, reaping and joining.
trueand short Bash captures averaged about 101 ms each.After: 25 captures each averaged about 1.7 ms and 3.5 ms respectively. The local probe is ignored in CI and has no timing assertion.
cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings, shared-owner and session recovery checks, and existing Harness/process-tree checks. Fullcargo test: 1264 passed, 0 failed, 1 ignored (the local latency probe).Test seams
Unaddressed findings
Standards
None. The one finding, possible Data Clumps in the execution settings, was addressed by the immutable
Controlvalue and confirmed resolved in the follow-up review.Spec
None. The Spec review reported no findings.
Merge Danger
Door: two-way
The extraction can be reverted; it changes no persisted data.
Blast Radius: Execution
Harness checks and sessions share this owner. Cancellation, transport recovery and descendant cleanup are the sensitive paths covered by the lifecycle and existing integration checks.
Built with codex · gpt-6.1-sol · xhigh