Repository navigation
Own child Run execution for Spec runs and Base fixes - #464
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Malformed Harness diagnostics now preserve a child Run's actual ending. Child Run execution owns its process and readers through completion; Spec runs poll owned handles, and Base fixes keep their synchronous wait and Running mark.
Closes #463
Evidence
malformed_stderr_preserves_a_successful_ending_and_base_fix_accountfailed withcould not read the Run for #248: stream did not contain valid UTF-8.After: It passes and relays the replacement character while retaining the PR URL and Base fix account.
After: It drains over 1 MiB before the caller waits and returns the last stdout line as the PR URL.
main: Standards found one minor duplicated fixture setup, addressed withFixture::start_with_fault; Spec found no issues.cargo fmt --check,cargo clippy --all-targets -- -D warnings, andcargo testpassed (1,252 tests; zero failures). The full suite includes all 58 Spec run and 13 Base fix integration tests.Seams under test: child Run execution through start/try_wait/wait/drop with finite local executable fixtures and private fault injection; Spec run and Base fix command interfaces through their integration fixtures. Existing hidden-argument and Run ending tests remain separate.
Merge Danger
Door: two-way
Reversible execution refactor; no persistent-format changes. Child Runs retain their existing unbounded graceful shutdown and shared process groups.
Blast Radius: execution
Child Ticket Runs and Base fixes, including output relay and interruption cleanup.
Unaddressed findings
Standards
None. The single finding was addressed.
Spec
None. No findings were reported.
Built with codex · gpt-6.1-sol · xhigh