Repository navigation
Retain Harness interpretation after transport failures - #462
Merged
Merged
Conversation
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failed Harness sessions keep recoverable usage and warnings while preserving the original transport error.
The process module now owns recovery after every normal consumer return. Session uses the returned interpretation directly; interruption suppresses recovery and completion reporting.
Closes #461
Evidence
completed_stdout_is_reported_after_a_broken_promptfailed withleft: 0, right: 1for the missing-skill warning. Successful stdout consumption followed by BrokenPipe lost retained export, usage and completion reporting.After: the regression passes with the original BrokenPipe cause, the exact child PID reaped, one retained export, one warning, one usage summary and one session-ended line.
cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings, andcargo test(1,240 tests passed).Seams under test:
streaming: recovered state, execution errors, owned cleanup and worker completion.Sessions::within/run_to_final_message) with local shell CLI fixtures: retained reads, reporting, interruption and Resume eligibility.Merge Danger
Door: two-way
The internal interface change can be reverted without a data migration.
Blast Radius: Sessions
Harness session execution and completion reporting across all six Harnesses.
Unaddressed findings
Standards
None. Review against
mainreported no findings.Spec
None. Review against #461 reported no findings.
Built with codex · gpt-6.1-sol · xhigh