Repository navigation
Deepen completed Harness session interpretation - #458
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failed Harness turns now fail the Run even when the CLI exits zero. One consuming interpretation owns retained-data authority, completion reporting, and validation for sessions and Muse/OpenCode Model/Effort checks.
Closes #457
Evidence
a_zero_exit_failed_claude_turn_leaves_the_pr_draft_without_a_resumefailed: the Run returned0and reported its PR ready after Claude emittederror_max_turns.After: the regression passes: the Run fails, leaves the PR draft, and starts no Resume.
interrupted; check-export interruption also stops descendants before any work.cargo fmt --check,cargo check, andcargo clippy --all-targets -- -D warningspassed.cargo testpassed on the final implementation.thirdshift-code-reviewagainstmain: addressed the Standards finding by sharing duplicated test setup and the Spec finding by preserving interruption wording in captured checks.Test seams
Unaddressed findings
Standards
None. The duplicated test helper finding was addressed.
Spec
None. The captured-check interruption wording finding was addressed.
Merge Danger
Door: two-way
Revert restores the previous interpretation implementation; no persisted-data migration is needed.
Blast Radius: Harnesses
Completion behavior covers all six Harnesses and Muse/OpenCode preflight checks.
Built with codex · gpt-6.1-sol · xhigh