Skip to content

Own all Model/Effort checks and make Setup interruptible - #453

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-452
Oct 6, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-452

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Model/Effort checks now share Harness process ownership. Terminal Setup cancellation exits 1 with interrupted, restores terminal attributes and leaves the User config and Credentials unchanged.

Command / Setup check
  Harness process owner
    write and close optional stdin; capture both output pipes
    interruption → adapter stop → reap CLI and join I/O workers

Setup question
  persistent signal recording → poll stdin → restore saved attributes

Closes #452

Evidence

  • Before: Live-check regressions for Claude, Codex, agy and Grok each failed: interruption waited for the check and a Command log was created.
    After: Live checks, detached descendants and after-exit pipe holders stop within the regression deadlines. Exact recorded owned PIDs terminate before any Claim, worktree or Command log.
  • Both Setup entry paths cover all six Harness I/O catches. Later ordinary/hidden questions remain interruptible after successful and refused/repeated checks; UTF-8 paste, partial-line EOF and terminal restoration pass.
  • Validation (Linux): cargo check --all-targets, cargo fmt --check, cargo clippy --all-targets -- -D warnings, and the full cargo test suite pass.
  • CI: the full Linux and macOS suites pass, along with the Linux and macOS artifact builds. Terminal regressions retain exact attribute checks across both platforms.
  • Review against main: both Standards findings addressed; no Spec findings.

Test seams

  • Command startup through real thirdshift processes and fake Harness executables.
  • Production Setup terminal input through explicit Setup and the first Run's offer.
  • Existing Harness process captured-output and streaming interfaces.

Merge Danger

Door: two-way

Reversible implementation changes; no data migration.

Blast Radius: Harnesses

Command preflight and terminal Setup across all six Harnesses.

Unaddressed findings

Standards

None. Both findings were addressed.

Spec

None. The review reported no findings.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 0e9a40c into main Oct 6, 2026
13 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-452 branch October 6, 2026 21:04
This was referenced Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deepen Harness process ownership across every Model/Effort check

1 participant