[JacobStephens2]

Summary

Setup and its first-Run offer use one prepared User config document for completed question defaults and semantic edits. Validation, defaults completion, and TOML preservation now belong to the User config module.

UserConfigDocument::existing / ::defaults
  validate as a Run → complete defaults → settings for questions
render(semantic changes | none)
  preserve spelling, comments, order, and unasked settings
Setup
  write User config → save Credentials → send test email

Closes #450

Evidence

• Before: enabling_notifications_replaces_examples_at_section_and_document_boundaries failed because the active recipient preceded # mine; quoted_email_headers_keep_one_example_and_render_idempotently found two examples instead of one.
  After: both regressions pass through the prepared document interface; all 31 User config tests and 62 Setup flow tests pass.
• CLI and terminal regressions: Setup 10/10, Setup offer 7/7, User config 14/14. The added file test verifies atomic replacement, retained permissions, and no replacement for unchanged completed text.
• cargo check --all-targets, cargo fmt --check, and cargo clippy --all-targets -- -D warnings pass.
• Full suite: cargo test — 1,195 passed, 0 failed, 0 ignored across 39 test binaries.

Test seams

• User config prepared document: existing/default construction, completed settings, and consuming semantic rendering.
• Setup Outside adapter: questions, cancellation, refusal, and write/Credentials/email ordering.
• CLI and terminal: actual User config files, permissions, atomic replacement, and the first-Run Setup offer.

Merge Danger

Door: two-way

Reversible implementation change; existing User config format and Credentials handling are preserved.

Blast Radius: Setup

User config preparation/editing and both Setup entry paths.

Unaddressed findings

Standards

None. The review against main found no Standards findings.

Spec

None. Both Spec findings were addressed: recipient-example placement at section/document boundaries (P1), and quoted-header completion idempotence (P2). Re-review found no additional gaps.

Built with codex · gpt-6.1-sol · xhigh