Repository navigation
Add Muse Code Harness - #444
Merged
Merged
Conversation
# Conflicts: # src/harness.rs # tests/fakes.rs # tests/support/fakes.rs
Preserve agy's catalog validation and instruction fallback alongside Muse's skill loading and final-reply recovery. Combine both Harnesses in registration, Setup, User config, documentation and scenario fakes. Validated with cargo check --locked --all-targets, cargo test --locked --quiet (1127 passed), cargo clippy --locked --all-targets -- -D warnings, cargo fmt --check and git diff --check.
This was referenced Oct 6, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Muse Code through the registered Harness adapter, including Resume, linked Factory skills, progress, Model/Effort validation, and Setup's
muse-spark-1.3proposal. Documents Muse's contributor default and unattended invocation in ADR 0013.Closes #438
Evidence
cargo test --test muse_sessionsrejectedharness muse.After: all 10 Muse scenarios pass, covering invocation, validation before work, Setup, Resume, failure, missing skill warnings, native logs, and Architecture review's last reply.
After: the fake emits multiple replies with Muse's model boundary; the scenario and recorded-stream regression pass with the parser restored.
After: a minimal Muse 1.4.2 probe confirmed
read_skilldetection, session id, last reply, and token usage; an offline probe confirmed XDG data-directory handling.cargo test --quiet(1107 passed, 0 failed),cargo clippy --all-targets -- -D warnings, andcargo fmt --checkpass.UPDATE_PROMPTS=1 cargo test --bin thirdshift prompts_pagepasses with no generated changes.Test seams
Outsideseam for validation refusal and retry.Review with
thirdshift-code-reviewagainstissue-432at7136bcd: Standards reported no findings; Spec confirmed the fallback coverage finding is addressed, with no remaining findings. The latest base is merged, preserving its process-tree stopping.Merge Danger
Door: two-way
Reverting removes the new Harness; users configured for Muse would need to choose another Harness.
Blast Radius: Sessions
Shared changes pass the prompt to the adapter's stream and emit its warnings after exit. Setup now lists installed Harnesses. Missing or unreadable Muse logs retain the stream's last reply without usage.
Unaddressed findings
Standards
None; the review reported no confirmed findings.
Spec
None; the last-reply fallback coverage finding was addressed.
Built with codex · gpt-6.1-sol · xhigh