Repository navigation
Stop every Harness session process tree on interruption - #443
Merged
Merged
Conversation
This was referenced Oct 6, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interrupting a Command stops each session's whole process tree on every Harness, including commands that created their own process group or session.
Closes #435
Evidence
interrupting_a_claude_run_stops_a_command_in_its_own_sessionfailed: "the detached command survived interruption".After:
cargo test --test process_tree --test codex_sessions --test failed_runpasses all 26 tests, covering detached commands on Claude and Codex, Codex's SIGINT → SIGTERM order, and prompt cleanup after the CLI exits.a_command_started_during_the_stop_grace_period_is_killed_toofail; restoring it passes.cargo check --all-targets,cargo fmt --check, andcargo clippy --all-targets -- -D warningspass.cargo test: 1089 passed, 0 failed, 0 ignored across 35 test targets.Seam under test: real Runs through the scenario harness with fake CLIs on PATH; observe recorded stop signals and the detached command's recorded pid after interruption.
Review against
issue-432at860f48e: one Standards finding (duplicated test polling) addressed and verified by the reviewer; no Spec findings.Merge Danger
Door: two-way
Blast Radius: sessions
Descendant discovery requires
pson PATH. A snapshot failure warns and still stops every known process group.Unaddressed findings
Standards
None. The single finding was addressed.
Spec
None. No findings were reported.
Built with codex · gpt-6.1-sol · xhigh