Repository navigation
Gather Claude and Codex into Harness adapters - #441
Merged
Merged
Conversation
This was referenced Oct 6, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude and Codex each own their session protocol behind one Harness adapter. Sessions, Setup and User config use the registered adapters while preserving existing behavior.
The adapter owns CLI/product names, new-session and Resume arguments, skill loading, skills location, instruction fallback, environment, stop signals, checks and stream parsing. Optional hooks cover instruction-file links and reading final text, usage and outcome after exit. Harness enumeration and choice messages come from adapter registrations.
Closes #434
Evidence
issue-432passed all 55 existing Codex sessions, Harness choice, Setup, User config, progress lines and background work scenario tests.After: those same 55 tests pass unchanged through the adapters. Existing Harness, Session, progress, Setup and Codex parser test bodies are unchanged; ticket 1 adds no tests.
cargo check --all-targets,cargo fmt --checkandcargo clippy --all-targets -- -D warningspass.UPDATE_PROMPTS=1 cargo test prompts_page: 8 tests pass; regeneration produces no diff inprompts/.cargo test: full suite passes (1086 passed, 0 failed, 0 ignored across 34 test binaries).thirdshift-code-reviewagainstissue-432(d7e4a2c): Standards 0 findings; Spec 0 findings.Test seams
Unaddressed findings
Standards
None: the review reported no findings.
Spec
None: the review reported no findings.
Merge Danger
Door: two-way
Can be reverted independently.
Blast Radius: Harnesses
Affects Harness selection, Setup and session execution across Runs and Resumes.
Built with codex · gpt-6.1-sol · xhigh