Repository navigation
One Spec PR module owns the Spec PR in a Spec run - #369
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Spec PR's lifecycle in a Spec run moves into one module, a sibling of the Ticket board. The Spec run's loop tells it what happened, and stops carrying an
Option<PullRequest>and the Base branch.src/spec_run.rs # loop: tells the Spec PR "show" / "landed" +src/spec_run/spec_pr.rs # resume, show, landed, put_back, url; markers; opening body src/spec_run/ticket_board.rs # checklist is `## Tickets` + lines, no markersPer Decision 3,
landedbefore the Spec review now also reads the body when the Spec PR is already open; it writes nothing because the checklist already matches.Evidence
main,cargo testpasses, including 75 Spec run end-to-end tests.After:
cargo testpasses on this branch, and the 75 Spec run tests are unchanged and still pass. These include: opening as a draft once the first Ticket lands, the checklist being put back after the Spec review, replacement between the markers, putting it back after a failed Spec review, a refused checklist update being only a warning, and a failed Ticket showing in an open Spec PR's checklist.cargo clippy --all-targets -- -D warningsis clean.with_checklistunit tests moved tospec_pr.rs. They now pass the bare checklist, andwith_checklistwraps it in the markers itself. The Ticket board's checklist test expects no markers.Merge Danger
Door: two-way
A refactor inside the Spec run with no user-visible change. Reverting this PR undoes it.
Blast Radius: Spec runs
If this is wrong, it shows up as a Spec PR that doesn't open, isn't drafted, or loses its Tickets checklist. The unchanged end-to-end tests cover each of these.
Unaddressed findings
Standards
show/put_backshould bewrite_or_warn/write. Skipped: Decision 2 names the operations after what happened in the Spec run, not after how they fail.landedboth commands and queries (returns the URL). Skipped: Decision 2 specifieslanded(checklist) → URLso the Spec review gets the URL from the call that guarantees the Spec PR is open.Spec
Closes #367
🤖 Generated with Claude Code