Repository navigation
Close #275: main already fixes the OpenSSL check on a fresh cargo registry - #276
Merged
Merged
Conversation
`cargo tree --target all` reads the manifest of every locked crate, and a build only downloads the host's. With `--offline` the test passed only where the registry already held the Windows and Android crates: CI's cache did until Rust 1.99.0 changed its key, and then both jobs failed on android_system_properties. `--locked` replaces `--offline`, so cargo downloads what is missing and resolves nothing new. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The missing crates are every other platform's, not only Windows and Android. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… tree one main fixed the same test in #274 while this branch was underway: it reads Cargo.lock, so it needs no registry at all. This branch let cargo tree download the missing crates instead. One test can't do both, and main's is merged, stricter and never touches the network, so the branch now matches main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #275
This pull request changes no files.
mainfixed the failure in #274 while this branch was underway, and CI onmainis green again at 59fd86c. Merging this only closes #275; closing it unmerged and closing #275 by hand does the same.Both jobs in #275 failed in one test,
the_binary_never_links_openssl, and no commit caused it: Rust 1.99.0 was released, the CI cache key changed, and the registry started with the host's crates only.The branch's two commits swapped
--offlinefor--locked. They conflicted with #274 on the same test. The merge takesmain's version whole: it is already reviewed and merged, it is stricter (dev-dependencies count too), and it never touches the network.Seam tested. None added; the branch's tree equals
main's.Evidence
mainat 362b9ca, CI run 36863646811, both jobs:mainat 59fd86c, CI run 36882844210: success.git diff origin/mainon this branch after the merge: empty.testandtest-macospass.cargo fmt --check,cargo clippy --all-targets -- -D warningsand the fullcargo testpass.--lockedchange did work on a registry holding only the host's crates (3 passed, where--offlinefailed as above), and still caughtnative-tlswhen it was added to reqwest's features. It is in the branch history, commits cc7ecf2 and the one after.Unaddressed findings
The review ran on the
--lockedchange, before the merge withmainreplaced it.Standards
package_list()still passes--offline: left as is. The reviewer judged it correct, andcargo package --list --offlinepassed on the cold registry in both failing jobs.Spec
main.Merge Danger
Door: two-way
No file changes.
Blast Radius: none
🤖 Generated with Claude Code