Skip to content

Close #275: main already fixes the OpenSSL check on a fresh cargo registry - #276

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-275
Oct 1, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-275

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes #275

This pull request changes no files. main fixed the failure in #274 while this branch was underway, and CI on main is green again at 59fd86c. Merging this only closes #275; closing it unmerged and closing #275 by hand does the same.

Both jobs in #275 failed in one test, the_binary_never_links_openssl, and no commit caused it: Rust 1.99.0 was released, the CI cache key changed, and the registry started with the host's crates only.

362b9ca   cargo tree --target all --offline   needs android_system_properties, can't download: fails
#274      read Cargo.lock                     no registry needed                    <- on main, kept
branch    cargo tree --target all --locked    downloads the missing crates          <- dropped in the merge

The branch's two commits swapped --offline for --locked. They conflicted with #274 on the same test. The merge takes main's version whole: it is already reviewed and merged, it is stricter (dev-dependencies count too), and it never touches the network.

Seam tested. None added; the branch's tree equals main's.

Evidence

  • Before: main at 362b9ca, CI run 36863646811, both jobs:
    test the_binary_never_links_openssl ... FAILED
    error: failed to download `android_system_properties v0.1.6`
      attempting to make an HTTP request, but --offline was specified
    
    After: main at 59fd86c, CI run 36882844210: success.
  • git diff origin/main on this branch after the merge: empty.
  • This pull request's own CI run 36884518840: test and test-macos pass.
  • Locally on the merged branch, Rust 1.98.1: cargo fmt --check, cargo clippy --all-targets -- -D warnings and the full cargo test pass.
  • The dropped --locked change did work on a registry holding only the host's crates (3 passed, where --offline failed as above), and still caught native-tls when it was added to reqwest's features. It is in the branch history, commits cc7ecf2 and the one after.

Unaddressed findings

The review ran on the --locked change, before the merge with main replaced it.

Standards

  • package_list() still passes --offline: left as is. The reviewer judged it correct, and cargo package --list --offline passed on the cold registry in both failing jobs.
  • (Addressed before the merge, now moot: the comment moved beside the flag, and "Windows and Android" became "other platforms".)

Spec

  • None skipped. The one finding, that only a green CI run on Rust 1.99.0 confirms the whole suite, is answered by run 36882844210 on main.

Merge Danger

Door: two-way

No file changes.

Blast Radius: none

🤖 Generated with Claude Code

JacobStephens2 and others added 3 commits October 1, 2026 15:21
`cargo tree --target all` reads the manifest of every locked crate, and a
build only downloads the host's. With `--offline` the test passed only
where the registry already held the Windows and Android crates: CI's
cache did until Rust 1.99.0 changed its key, and then both jobs failed on
android_system_properties. `--locked` replaces `--offline`, so cargo
downloads what is missing and resolves nothing new.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The missing crates are every other platform's, not only Windows and
Android.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… tree one

main fixed the same test in #274 while this branch was underway: it reads
Cargo.lock, so it needs no registry at all. This branch let cargo tree
download the missing crates instead. One test can't do both, and main's is
merged, stricter and never touches the network, so the branch now matches
main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JacobStephens2 JacobStephens2 changed the title Let the OpenSSL check pass on a fresh cargo registry Close #275: main already fixes the OpenSSL check on a fresh cargo registry Oct 1, 2026
@JacobStephens2
JacobStephens2 merged commit bd7946b into main Oct 1, 2026
13 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-275 branch October 1, 2026 15:56
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI red on main: test-macos, test

1 participant