Repository navigation
Inherited failures fail the Run without a Repair - #225
Merged
Merged
Conversation
A failed check that also failed, under the same name, on the Base branch commit the head last merged in is an Inherited failure (ADR 0008). The CI watcher now splits the failed checks into the branch's own and Inherited ones. A CI-fix Repair is given only the branch's own, with the Inherited ones listed as not to fix. When only Inherited failures are left, the Run merges the Base branch again if it moved, and otherwise fails naming the checks, the Base branch and its commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tively, test a still-red moved Base branch A check is an Inherited failure only if every check of its name on the Base branch commit failed. Commit statuses and a Base branch that moved but is still red are now covered through the binary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A failed check that also failed on the Base branch commit the head last merged in is an Inherited failure (ADR 0008). The Run now recognises it itself, before any Repair.
prompts/ci-fix-repair-inherited.md. README updated.Seam under test: the existing black-box seam, the real binary with the fake
ghandclaude(tests/support::Scenario), setting checks on both commits withgh fake checks/gh fake statuses. The prompt page keeps its golden-file test.Evidence
checks_that_also_fail_on_the_base_branch_commit_fail_the_run_without_a_repairfailed: the Run printedCI red; starting Repair 1 of 5and started arepair-1session.After: it passes: one session (implement), stderr has
Inherited failures (also failing on main at <sha>): test, lint, deploy/previewand the cause, the PR is a draft, and the failure commit isthirdshift: failed run (CI red on test, lint, deploy/preview, which also fails on main at <sha>; fix main first).New tests, by acceptance criterion:
cargo test: 467 passed, 0 failed. The existing CI tests pass with no change to their bodies.cargo fmt --checkandcargo clippy --all-targetsare clean.Merge Danger
Door: two-way
Reverting restores a CI-fix Repair for every red check.
Blast Radius: Runs with red CI
gherror in the loop.origin/<base> kept moving, not the Inherited failure cause, because each round counts as a Base move.Unaddressed findings
Standards
FailedChecks { own, inherited }has public fields, so the loop knows that an emptyownmeans "all Inherited" (suggested: a thirdCivariant or a method). Skipped: the loop needs both lists in the mixed case, and a third variant would carry the same list in two shapes.ci::watchnow both watches and compares. Skipped: the Spec (Inherited failures: fail fast on a red Base branch, or fix it with a Base fix #221) asks for exactly this ("the result of watching CI grows to separate the branch's own failures from Inherited failures").base_branch_moved+count_base_movein both the green and red arms. Skipped: two lines with different follow-ups (return or go round); a helper would hide more than it saves.<base>at<sha>" in the progress line and the cause. Skipped: two different sentences that share a clause; the cause's wording is fixed by the issue.checks_on_base/inherited_failurehelpers written per test file. Skipped: the repo's test files each keep their own copies of such helpers (checks_on_head,RED,base_moves_on).Spec
git merge-base HEAD origin/<base>picks one best common ancestor. Skipped: the Issue branch only ever merges the Base branch in, so the newest merged Base commit is the merge base; it also holds when another Run's fetch moves the shared remote-tracking ref.kept moving, not the Inherited failure cause. Skipped: the issue says such a round is "counted as a Base move", and the budget's own cause is what a spent budget reports.Inherited failures (…)progress line, README edits. Kept:prompts/must show every prompt the binary sends, the progress line is story 33 of Inherited failures: fail fast on a red Base branch, or fix it with a Base fix #221, and the README documents the Run's behavior.Closes #103
🤖 Generated with Claude Code